Attachment 914597 Details for Bug 1037331 – Fix FTBFS with -Werror=format-security

[patch] Fix FTBFS with -Werror=format-security

Fix-FTBFS-with--Werrorformat-security-1037331-1107.patch (text/plain), 2.21 KB, created by Yaakov Selkowitz on 2014-07-03 22:54:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yaakov Selkowitz

Created: 2014-07-03 22:54:46 UTC

Size: 2.21 KB

patch

obsolete

>From ff47d4a1d2e3e5e7206e966a44fe8fdc7e420e9f Mon Sep 17 00:00:00 2001
>From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>Date: Thu, 3 Jul 2014 17:54:10 -0500
>Subject: [PATCH] Fix FTBFS with -Werror=format-security (#1037331, #1107349)
>
>---
> snownews-1.5.12-format-security.patch | 11 +++++++++++
> snownews.spec                         |  7 ++++++-
> 2 files changed, 17 insertions(+), 1 deletion(-)
> create mode 100644 snownews-1.5.12-format-security.patch
>
>diff --git a/snownews-1.5.12-format-security.patch b/snownews-1.5.12-format-security.patch
>new file mode 100644
>index 0000000..8109271
>--- /dev/null
>+++ b/snownews-1.5.12-format-security.patch
>@@ -0,0 +1,11 @@
>+--- a/zlib_interface.c
>++++ b/zlib_interface.c
>+@@ -93,7 +93,7 @@ int jg_zlib_uncompress(void const *in_buf, int in_size,
>+ 				free(out_buf);
>+ 				if (JG_ZLIB_DEBUG) {
>+ 					snprintf (tmpstring, sizeof(tmpstring), "ERROR: zlib_uncompress: %d %s\n", result, stream.msg);
>+-					fprintf(stderr, tmpstring);
>++					fprintf(stderr, "%s", tmpstring);
>+ 				}
>+ 				return JG_ZLIB_ERROR_UNCOMPRESS;
>+ 		}
>diff --git a/snownews.spec b/snownews.spec
>index c8923c8..0ea1c08 100644
>--- a/snownews.spec
>+++ b/snownews.spec
>@@ -1,6 +1,6 @@
> Name:		snownews
> Version: 	1.5.12
>-Release: 	10%{?dist}
>+Release: 	11%{?dist}
> Summary: 	A text mode RSS/RDF newsreader
> Group: 		Applications/Internet
> License: 	GPLv2
>@@ -10,6 +10,7 @@ Patch0:		snownews-1.5.10-nocheck.patch
> Patch1:		snownews-1.5.10-nostrip.patch
> Patch2:		snownews-1.5.12-manpage.patch
> Patch3:		snownews-1.5.12-ncursesw.patch
>+Patch4:		snownews-1.5.12-format-security.patch
> BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> BuildRequires:	libxml2-devel
> BuildRequires:	ncurses-devel
>@@ -30,6 +31,7 @@ with any version of libxml2.
> %patch1 -p1
> %patch2 -p1
> %patch3 -p1
>+%patch4 -p1
> 
> %build
> ./configure --prefix=%{_prefix}
>@@ -53,6 +55,9 @@ rm -rf $RPM_BUILD_ROOT
> %{_mandir}/*/man1/*
> 
> %changelog
>+* Thu Jul 03 2014 Yaakov Selkowitz <yselkowi@redhat.com> - 1.5.12-11
>+- Fix FTBFS with -Werror=format-security (#1037331, #1107349)
>+
> * Sun Jun 08 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.5.12-10
> - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
> 
>-- 
>1.9.3

Actions: View | Diff

Attachments on bug 1037331: 914597