Attachment 914598 Details for Bug 1036992 – Fix FTBFS with -Werror=format-security

[patch] Fix FTBFS with -Werror=format-security

Fix-FTBFS-with--Werrorformat-security-1036992-1105.patch (text/plain), 3.36 KB, created by Yaakov Selkowitz on 2014-07-03 23:15:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Yaakov Selkowitz

Created: 2014-07-03 23:15:39 UTC

Size: 3.36 KB

patch

obsolete

>From 25b16e75c81ae241a980d1ce43b2ac95ef8e0f6f Mon Sep 17 00:00:00 2001
>From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>Date: Thu, 3 Jul 2014 18:14:54 -0500
>Subject: [PATCH] Fix FTBFS with -Werror=format-security (#1036992, #1105965)
>
>---
> aqemu-0.8.2-format-security.patch | 38 ++++++++++++++++++++++++++++++++++++++
> aqemu.spec                        |  8 +++++++-
> 2 files changed, 45 insertions(+), 1 deletion(-)
> create mode 100644 aqemu-0.8.2-format-security.patch
>
>diff --git a/aqemu-0.8.2-format-security.patch b/aqemu-0.8.2-format-security.patch
>new file mode 100644
>index 0000000..ec9b48c
>--- /dev/null
>+++ b/aqemu-0.8.2-format-security.patch
>@@ -0,0 +1,38 @@
>+--- a/Utils.cpp
>++++ b/Utils.cpp
>+@@ -66,9 +66,9 @@ void AQDebug( const QString &sender, const QString &mes )
>+ 		std::cout << QString( "\nAQEMU Debug [%1] >>>\nSender: %2\nMessage: %3" )
>+ 							  .arg(Messages_Index).arg(sender).arg(mes).toStdString();
>+ 	#else
>+-		qDebug( qPrintable(QString(
>++		qDebug() << QString(
>+ 			"\n\33[32mAQEMU Debug\33[0m [%1] >>>\n\33[32mSender:\33[0m %2\n\33[32mMessage:\33[0m %3")
>+-			.arg(Messages_Index).arg(sender).arg(mes)) );
>++			.arg(Messages_Index).arg(sender).arg(mes);
>+ 	#endif
>+ 	}
>+ 	
>+@@ -87,9 +87,9 @@ void AQWarning( const QString &sender, const QString &mes )
>+ 		std::cout << QString( "\nAQEMU Warning [%1] >>>\nSender: %2\nMessage: %3" )
>+ 							  .arg(Messages_Index).arg(sender).arg(mes).toStdString();
>+ 	#else
>+-		qDebug( qPrintable(QString(
>++		qDebug() << QString(
>+ 			"\n\33[34mAQEMU Warning\33[0m [%1] >>>\n\33[34mSender:\33[0m %2\n\33[34mMessage:\33[0m %3")
>+-			.arg(Messages_Index).arg(sender).arg(mes)) );
>++			.arg(Messages_Index).arg(sender).arg(mes);
>+ 	#endif
>+ 	}
>+ 	
>+@@ -108,9 +108,9 @@ void AQError( const QString &sender, const QString &mes )
>+ 		std::cout << QString( "\nAQEMU Error [%1] >>>\nSender: %2\nMessage: %3" )
>+ 							  .arg(Messages_Index).arg(sender).arg(mes).toStdString();
>+ 	#else
>+-		qDebug( qPrintable(QString(
>++		qDebug() << QString(
>+ 			"\n\33[31mAQEMU Error\33[0m [%1] >>>\n\33[31mSender:\33[0m %2\n\33[31mMessage:\33[0m %3")
>+-			.arg(Messages_Index).arg(sender).arg(mes)) );
>++			.arg(Messages_Index).arg(sender).arg(mes);
>+ 	#endif
>+ 	}
>+ 	
>diff --git a/aqemu.spec b/aqemu.spec
>index ee6d576..e9d6396 100644
>--- a/aqemu.spec
>+++ b/aqemu.spec
>@@ -1,6 +1,6 @@
> Name: aqemu
> Version: 0.8.2
>-Release: 11%{?dist}
>+Release: 12%{?dist}
> Summary: A QT graphical interface to QEMU and KVM
> Group: Applications/Emulators
> License: GPLv2+
>@@ -12,6 +12,8 @@ Patch0: aqemu-0.8.2-fedora-desktop.patch
> # Fatch for vncview.cp file to disable macro that clashes with QT 4.8.
> # Upstram: http://sourceforge.net/tracker/?func=detail&aid=3429937&group_id=229794&atid=1078458
> Patch1: aqemu-0.8.2-qt48.patch
>+# -Werror=format-security
>+Patch2: aqemu-0.8.2-format-security.patch
> BuildRequires: qt-devel 
> BuildRequires: cmake 
> BuildRequires: libvncserver-devel
>@@ -28,6 +30,7 @@ majority of QEMU and KVM options on their virtual machines.
> %setup -q
> %patch0 
> %patch1  
>+%patch2 -p1
> 
> %build
> %cmake
>@@ -70,6 +73,9 @@ fi
> %{_mandir}/man1/%{name}.1*
> 
> %changelog
>+* Thu Jul 03 2014 Yaakov Selkowitz <yselkowi@redhat.com> - 0.8.2-12
>+- Fix FTBFS with -Werror=format-security (#1036992, #1105965)
>+
> * Sat Jun 07 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.8.2-11
> - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
> 
>-- 
>1.9.3

Actions: View | Diff

Attachments on bug 1036992: 914598