Attachment 918554 Details for Bug 1105335 – still better

[patch] still better

0001-assert.h-allow-gcc-to-detect-assert-a-1-errors.patch (text/plain), 1.73 KB, created by Jim Meyering on 2014-07-16 23:16:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jim Meyering

Created: 2014-07-16 23:16:20 UTC

Size: 1.73 KB

patch

obsolete

>From c1b16eda26d7370e45ff80f1862d5e0ab6dd079e Mon Sep 17 00:00:00 2001
>From: Jim Meyering <meyering@fb.com>
>Date: Thu, 5 Jun 2014 10:42:05 -0700
>Subject: [PATCH] assert.h: allow gcc to detect assert(a = 1) errors
>
>* assert/assert.h (assert): Rewrite assert's definition so that
>a s/==/=/ typo, e.g., assert(errno = ENOENT) is not hidden from
>gcc's -Wparentheses by the parentheses added by assert.
>The new definition uses "if (expr) ; else __assert_fail...", so
>gcc -Wall will now detect that type of error in an assert, too.
>---
> assert/assert.h | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
>diff --git a/assert/assert.h b/assert/assert.h
>index 2661391..4d7b3fc 100644
>--- a/assert/assert.h
>+++ b/assert/assert.h
>@@ -82,10 +82,24 @@ extern void __assert (const char *__assertion, const char *__file, int __line)
> 
> __END_DECLS
> 
>-# define assert(expr)							\
>-  ((expr)								\
>-   ? __ASSERT_VOID_CAST (0)						\
>-   : __assert_fail (__STRING(expr), __FILE__, __LINE__, __ASSERT_FUNCTION))
>+/* When possible, define assert so that it does not add extra
>+   parentheses around EXPR.  Otherwise, those added parentheses would
>+   suppress warnings we'd expect to be detected by gcc's -Wparentheses.  */
>+# if  !defined __GNUC__
>+#  define assert(expr)							\
>+    ((expr)								\
>+     ? __ASSERT_VOID_CAST (0)						\
>+     : __assert_fail (__STRING(expr), __FILE__, __LINE__, __ASSERT_FUNCTION))
>+# else
>+#  define assert(expr)							\
>+    __extension__							\
>+    ({									\
>+      if (expr)								\
>+        ; /* empty */							\
>+      else								\
>+        __assert_fail (__STRING(expr), __FILE__, __LINE__, __ASSERT_FUNCTION);\
>+    })
>+# endif
> 
> # ifdef	__USE_GNU
> #  define assert_perror(errnum)						\
>-- 
>1.8.1
>

Actions: View | Diff

Attachments on bug 1105335: 902693 | 902724 | 914882 | 918486 | 918491 | 918554 | 1223507