Attachment 919731 Details for Bug 1118289 – fedora-review.txt

fedora-review.txt

review.txt (text/plain), 7.78 KB, created by Shawn Iwinski on 2014-07-21 18:32:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shawn Iwinski

Created: 2014-07-21 18:32:14 UTC

Size: 7.78 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 8 files have unknown license.
>[x]: Package must own all directories that it creates.
>     Note: Directories without known owners: /usr/share/pear/Horde
>[x]: Package does not own files or directories owned by other packages.
>     Note: Dirs in package are owned also by: /usr/share/pear/Horde/Service
>     (php-horde-Horde-Service-Weather)
>
>     "Dirs in package are owned also by" are not dependencies of this package
>     so this package must also own the directory.
>
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[x]: Sources contain only permissible code or content.
>[!]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Package is not known to require an ExcludeArch tag.
>[x]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 40960 bytes in 4 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: Package requires other packages for directories it uses.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[!]: Buildroot is not present
>     Note: Buildroot: present but not needed
>[!]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: %clean present but not required
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Spec file according to URL is the same as in SRPM.
>     Note: Spec file as given by url is not the same as in SRPM (see attached
>     diff).
>     See: (this test has no URL)
>
>     Simple diff of comment.  Ignoring.
>
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note:  Time: 2.84 seconds, Memory: 11.25Mb Required PHP 5.2.0 (min)
>
>
>Rpmlint
>-------
>Checking: php-horde-Horde-Service-Gravatar-1.0.0-1.fc22.noarch.rpm
>          php-horde-Horde-Service-Gravatar-1.0.0-1.fc22.src.rpm
>php-horde-Horde-Service-Gravatar.noarch: W: spelling-error Summary(en_US) accessor -> accessory, access or, access-or
>php-horde-Horde-Service-Gravatar.src: W: spelling-error Summary(en_US) accessor -> accessory, access or, access-or
>2 packages and 0 specfiles checked; 0 errors, 2 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-horde-Horde-Service-Gravatar
>php-horde-Horde-Service-Gravatar.noarch: W: spelling-error Summary(en_US) accessor -> accessory, access or, access-or
>1 packages and 0 specfiles checked; 0 errors, 1 warnings.
># echo 'rpmlint-done:'
>
>
>
>Diff spec file in url and in SRPM
>---------------------------------
>--- /home/siwinski/projects/fedora/reviews/1118289-php-horde-Horde-Service-Gravatar/srpm/php-horde-Horde-Service-Gravatar.spec	2014-07-20 14:03:29.755767863 -0400
>+++ /home/siwinski/projects/fedora/reviews/1118289-php-horde-Horde-Service-Gravatar/srpm-unpacked/php-horde-Horde-Service-Gravatar.spec	2014-07-10 07:38:58.000000000 -0400
>@@ -1,3 +1,3 @@
>-# spec file for php-horde-Horde-Service-Gravatar
>+# spec file for php-horde-Horde-OpenXchange
> #
> # Copyright (c) 2014 Remi Collet
>
>
>Requires
>--------
>php-horde-Horde-Service-Gravatar (rpmlib, GLIBC filtered):
>    /bin/sh
>    /usr/bin/pear
>    php(language)
>    php-channel(pear.horde.org)
>    php-json
>    php-pear(PEAR)
>    php-pear(pear.horde.org/Horde_Http)
>    php-pear(pear.horde.org/Horde_Url)
>    php-spl
>
>
>
>Provides
>--------
>php-horde-Horde-Service-Gravatar:
>    php-horde-Horde-Service-Gravatar
>    php-pear(pear.horde.org/Horde_Service_Gravatar)
>
>
>
>Source checksums
>----------------
>http://pear.horde.org/get/Horde_Service_Gravatar-1.0.0.tgz :
>  CHECKSUM(SHA256) this package     : 3afc6e8b1d17b7ae4890c16be279a8b6847a44be7f59029d552bb87a1d92caef
>  CHECKSUM(SHA256) upstream package : 3afc6e8b1d17b7ae4890c16be279a8b6847a44be7f59029d552bb87a1d92caef
>
>
>Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
>Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1118289
>Buildroot used: fedora-rawhide-x86_64
>Active plugins: Generic, PHP, Shell-api
>Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
>Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Actions: View

Attachments on bug 1118289: 919731 | 919732