Attachment 920529 Details for Bug 1122826 – [PATCH] Patch fixing the crash

[patch] [PATCH] Patch fixing the crash

rh1122826-selinux-hostname-crash.patch (text/plain), 1.60 KB, created by Jirka Klimes on 2014-07-24 12:59:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jirka Klimes

Created: 2014-07-24 12:59:00 UTC

Size: 1.60 KB

patch

obsolete

>From 487a7fa26eee24916bff1d1f608bc481a566883d Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ji=C5=99=C3=AD=20Klime=C5=A1?= <jklimes@redhat.com>
>Date: Thu, 24 Jul 2014 14:10:55 +0200
>Subject: [PATCH] ifcfg-rh: fix a crash on setting hostname with SELinux
> disabled (rh #1122826)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>When SELinux is disabled, getfscreatecon() fails leaving se_ctx_prev undefined
>and then later freecon (se_ctx_prev) fails with a crash. Initializing
>se_ctx_prev to NULL fixes the crash. (It is fine to pass NULL context to
>setfscreatecon).
>
>Testcase:
>1) Enable ifcfg-rh plugin in /etc/NetworkManger/NetworkManger.conf
>   plugins=ifcfg-rh
>2) Edit /etc/sysconfig/selinux to contain
>   SELINUX=disabled
>3) Reboot
>4) Set hostname via nmcli, nmtui or D-Bus SaveHostname() call
>5) NM crashes
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1122826
>
>Signed-off-by: JiÅÃ KlimeÅ¡ <jklimes@redhat.com>
>---
> src/settings/plugins/ifcfg-rh/plugin.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/settings/plugins/ifcfg-rh/plugin.c b/src/settings/plugins/ifcfg-rh/plugin.c
>index b067c58..0567ba2 100644
>--- a/src/settings/plugins/ifcfg-rh/plugin.c
>+++ b/src/settings/plugins/ifcfg-rh/plugin.c
>@@ -670,7 +670,7 @@ plugin_set_hostname (SCPluginIfcfg *plugin, const char *hostname)
> 	char *hostname_eol;
> 	gboolean ret;
> #if HAVE_SELINUX
>-	security_context_t se_ctx_prev, se_ctx = NULL;
>+	security_context_t se_ctx_prev = NULL, se_ctx = NULL;
> 	struct stat file_stat = { .st_mode = 0 };
> 
> 	/* Get default context for HOSTNAME_FILE and set it for fscreate */
>-- 
>1.7.11.7
>

Actions: View | Diff

Attachments on bug 1122826: 920458 | 920529