Attachment 925847 Details for Bug 1128877 – Log resource load errors on stdout and in logfile

[patch] Log resource load errors on stdout and in logfile

case1164593-rgmanager_do_load_resource_log_errors.patch (text/plain), 2.35 KB, created by John Ruemker on 2014-08-11 17:43:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John Ruemker

Created: 2014-08-11 17:43:22 UTC

Size: 2.35 KB

patch

obsolete

>diff -up rgmanager-3.0.12.1/rgmanager/src/daemons/restree.c.case1164593 rgmanager-3.0.12.1/rgmanager/src/daemons/restree.c
>--- rgmanager-3.0.12.1/rgmanager/src/daemons/restree.c.case1164593	2014-08-11 11:55:38.223708146 -0400
>+++ rgmanager-3.0.12.1/rgmanager/src/daemons/restree.c	2014-08-11 13:00:04.060345999 -0400
>@@ -591,6 +591,8 @@ do_load_resource(int ccsfd, char *base,
> 		}
> 
> 	       	if (store_resource(reslist, curres) != 0) {
>+			logt_print(LOG_ERR, "Error storing %s resource\n",
>+				curres->r_rule->rr_type);
> 	 		printf("Error storing %s resource\n",
> 	 		       curres->r_rule->rr_type);
> 	 		destroy_resource(curres);
>@@ -604,6 +606,8 @@ do_load_resource(int ccsfd, char *base,
> 		curres = find_resource_by_ref(reslist, rule->rr_type,
> 						      ref);
> 		if (!curres) {
>+			logt_print(LOG_ERR, "Error: Reference to nonexistent "
>+                                "resource %s (type %s)\n", ref, rule->rr_type);
> 			printf("Error: Reference to nonexistent "
> 			       "resource %s (type %s)\n", ref,
> 			       rule->rr_type);
>@@ -612,6 +616,9 @@ do_load_resource(int ccsfd, char *base,
> 		}
> 
> 		if (curres->r_flags & RF_INLINE) {
>+			logt_print(LOG_ERR, "Error: Reference to inlined "
>+                                "resource %s (type %s) is illegal\n",
>+                                ref, rule->rr_type);
> 			printf("Error: Reference to inlined "
> 			       "resource %s (type %s) is illegal\n",
> 			       ref, rule->rr_type);
>@@ -623,6 +630,9 @@ do_load_resource(int ccsfd, char *base,
> 
> 	/* Load it if its max refs hasn't been exceeded */
> 	if (rule->rr_maxrefs && (curres->r_refs >= rule->rr_maxrefs)){
>+		logt_print(LOG_WARNING, "Warning: Max references exceeded for "
>+                       "resource %s (type %s)\n", curres->r_attrs[0].ra_name,
>+                       rule->rr_type);
> 		printf("Warning: Max references exceeded for resource"
> 		       " %s (type %s)\n", curres->r_attrs[0].ra_name,
> 		       rule->rr_type);
>@@ -710,6 +720,8 @@ do_load_resource(int ccsfd, char *base,
> 	if (curres->r_refs > 1 &&
> 	    (curres->r_flags & RF_NON_CRITICAL)) {
> 		res_build_name(tok, sizeof(tok), curres);
>+		logt_print(LOG_WARNING, "Non-critical flag for %s is being "
>+                        "cleared due to multiple references.\n", tok);
> 		printf("Non-critical flag for %s is being cleared due to multiple references.\n", tok);
> 		curres->r_flags &= ~RF_NON_CRITICAL;
> 	}

Actions: View | Diff

Attachments on bug 1128877: 925847