Attachment 926551 Details for Bug 1129774 – CVE-2014-3594 patch for stable/havana

[patch] CVE-2014-3594 patch for stable/havana

cve-2014-3594-stable-havana.patch (text/plain), 1.77 KB, created by Vincent Danen on 2014-08-13 18:55:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vincent Danen

Created: 2014-08-13 18:55:34 UTC

Size: 1.77 KB

patch

obsolete

>From d05e3df3d359d3239048b548d57905d836cd478c Mon Sep 17 00:00:00 2001
>From: Julie Pichon <jpichon@redhat.com>
>Date: Thu, 7 Aug 2014 12:01:56 +0100
>Subject: [PATCH] Fix XSS issue with the unordered_list filter
>
>When using the unordered_list filter in a Horizon table (as opposed to
>a template directly), autoescaping is not set by default and the input
>wasn't sanitised.
>
>Closes-Bug: #1349491
>Change-Id: Id82eefe48ccb17a158751ec65d24f3ac779380ec
>---
> openstack_dashboard/dashboards/admin/info/tables.py | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/openstack_dashboard/dashboards/admin/info/tables.py b/openstack_dashboard/dashboards/admin/info/tables.py
>index d4f3fe7..a123fab 100644
>--- a/openstack_dashboard/dashboards/admin/info/tables.py
>+++ b/openstack_dashboard/dashboards/admin/info/tables.py
>@@ -127,6 +127,10 @@ def get_metadata(aggregate):
>             in aggregate.metadata.iteritems()]
> 
> 
>+def safe_unordered_list(value):
>+    return filters.unordered_list(value, autoescape=True)
>+
>+
> class AggregatesTable(tables.DataTable):
>     name = tables.Column("name",
>                          verbose_name=_("Name"))
>@@ -135,11 +139,11 @@ class AggregatesTable(tables.DataTable):
>     hosts = tables.Column(get_hosts,
>                           verbose_name=_("Hosts"),
>                           wrap_list=True,
>-                          filters=(filters.unordered_list,))
>+                          filters=(safe_unordered_list,))
>     metadata = tables.Column(get_metadata,
>                              verbose_name=_("Metadata"),
>                              wrap_list=True,
>-                             filters=(filters.unordered_list,))
>+                             filters=(safe_unordered_list,))
> 
>     class Meta:
>         name = "aggregates"
>-- 
>1.8.3.1
>
>

Actions: View | Diff

Attachments on bug 1129774: 926551 | 926552 | 926553