Attachment 930527 Details for Bug 1108522 – Cancel token holding while in retransmition

[patch] Cancel token holding while in retransmition

tmp.RlWgX9YEII (text/plain), 1.64 KB, created by Jan Friesse on 2014-08-25 14:40:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2014-08-25 14:40:03 UTC

Size: 1.64 KB

patch

obsolete

>From f135b680967aaef1d466f40170c75ae3e470e147 Mon Sep 17 00:00:00 2001
>From: Jason HU <huzhijiang@gmail.com>
>Date: Sat, 9 Aug 2014 06:44:31 +0800
>Subject: [PATCH] Cancel token holding while in retransmition
>
>When there is no other activty on ring but only retransmition, and
>token is in hold mode, the retransmition will become slow. More over,
>if the retransmition is always fail but token rotation works well, then
>it takes quite a lone time
>(fail_to_recv_const * token_hold = 2500 * 180ms = 450sec) for the
>retransmit requester to meet the "FAILED TO RECEIVE" condition to
>re-construct a new ring.
>
>This problem can be solved by checking if retransmits are present
>before going into hold. If a node is the retransmit requester or
>the resender, it set my_token_held to 0 to speed up retransmition
>and omit further unnecessary sending of token_hold_cancel signal.
>
>Signed-off-by: Jason HU <huzhijiang@gmail.com>
>Reviewed-by: Christine Caulfield <ccaulfie@redhat.com>
>---
> exec/totemsrp.c |    6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
>diff --git a/exec/totemsrp.c b/exec/totemsrp.c
>index dcda8d1..3b8d56b 100644
>--- a/exec/totemsrp.c
>+++ b/exec/totemsrp.c
>@@ -3650,6 +3650,12 @@ static int message_handler_orf_token (
> 		transmits_allowed = fcc_calculate (instance, token);
> 		mcasted_retransmit = orf_token_rtr (instance, token, &transmits_allowed);
> 
>+		if (instance->my_token_held == 1 &&
>+			(token->rtr_list_entries > 0 || mcasted_retransmit > 0)) {
>+			instance->my_token_held = 0;
>+			forward_token = 1;
>+		}
>+
> 		fcc_rtr_limit (instance, token, &transmits_allowed);
> 		mcasted_regular = orf_token_mcast (instance, token, transmits_allowed);
> /*
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1108522: 907995 | 907996 | 907997 | 907998 | 907999 | 908004 | 908111 | 930505 | 930506 | 930507 | 930509 | 930510 | 930511 | 930512 | 930513 | 930514 | 930515 | 930516 | 930517 | 930518 | 930519 | 930527 | 930528 | 930529 | 930530 | 930531 | 930535 | 930536 | 930537 | 930538 | 930539 | 930540 | 931024