Attachment 930537 Details for Bug 1108522 – ipc: Process votequorum messages during sync

[patch] ipc: Process votequorum messages during sync

tmp.6jgOWDzKGr (text/plain), 2.24 KB, created by Jan Friesse on 2014-08-25 14:43:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2014-08-25 14:43:38 UTC

Size: 2.24 KB

patch

obsolete

>From 7cad804629fe7d936d098569122f84979959b554 Mon Sep 17 00:00:00 2001
>From: Jan Friesse <jfriesse@redhat.com>
>Date: Thu, 31 Jul 2014 17:06:32 +0200
>Subject: [PATCH] ipc: Process votequorum messages during sync
>
>This is needed for qdevice to be able to process messages during
>synchronization phase.
>
>Signed-off-by: Jan Friesse <jfriesse@redhat.com>
>Reviewed-by: Christine Caulfield <ccaulfie@redhat.com>
>---
> exec/ipc_glue.c           |    9 ++++++++-
> man/votequorum_overview.8 |    9 +++++++++
> 2 files changed, 17 insertions(+), 1 deletions(-)
>
>diff --git a/exec/ipc_glue.c b/exec/ipc_glue.c
>index 355248a..79ee4df 100644
>--- a/exec/ipc_glue.c
>+++ b/exec/ipc_glue.c
>@@ -702,7 +702,14 @@ static void cs_ipcs_check_for_flow_control(void)
> 			 * now check flow control
> 			 */
> 			if (ipc_fc_totem_queue_level != TOTEM_Q_LEVEL_CRITICAL &&
>-				ipc_fc_sync_in_process == 0) {
>+			    ipc_fc_sync_in_process == 0) {
>+				fc_enabled = QB_FALSE;
>+			} else if (ipc_fc_totem_queue_level != TOTEM_Q_LEVEL_CRITICAL &&
>+			    i == VOTEQUORUM_SERVICE) {
>+				/*
>+				 * Allow message processing for votequorum service even
>+				 * in sync phase
>+				 */
> 				fc_enabled = QB_FALSE;
> 			} else {
> 				fc_enabled = QB_IPCS_RATE_OFF_2;
>diff --git a/man/votequorum_overview.8 b/man/votequorum_overview.8
>index bad4ecb..4fce38a 100644
>--- a/man/votequorum_overview.8
>+++ b/man/votequorum_overview.8
>@@ -56,6 +56,15 @@ The library provides a mechanism to:
> .PP
> * Connect an additional quorum device to allow small clusters to remain quorate during node outages.
> .PP
>+.SH VIRTUAL SYNCHRONY
>+Votequorum is the only one service where communication with library is allowed during synchronization
>+phase. This makes it possible for quorum device to react to membership change and decide to vote or
>+not without timing hazard, because corosync stands in synchronization phase until qdevice on all
>+nodes votes or timeout expires.
>+
>+As a side effect, extended virtual synchrony is broken for the votequorum service. This means, that
>+messages sent during synchronization phase can be delivered sooner then messages sent right
>+before sync phase began. This applies also for local messages.
> .SH BUGS
> No known bugs at the time of writing. The authors are from outerspace. Deal with it.
> .SH "SEE ALSO"
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 1108522: 907995 | 907996 | 907997 | 907998 | 907999 | 908004 | 908111 | 930505 | 930506 | 930507 | 930509 | 930510 | 930511 | 930512 | 930513 | 930514 | 930515 | 930516 | 930517 | 930518 | 930519 | 930527 | 930528 | 930529 | 930530 | 930531 | 930535 | 930536 | 930537 | 930538 | 930539 | 930540 | 931024