Attachment 930740 Details for Bug 1131731 – review.txt

review.txt

review.txt (text/plain), 7.39 KB, created by Remi Collet on 2014-08-26 05:58:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2014-08-26 05:58:52 UTC

Size: 7.39 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>
>[!]: Requires correct, justified where necessary.
>
>php-reflection detected by phpcompatinfo
>Ok, this one is always present, but, to be consistent, 
>as you BR it, you should also require it.
>
>[!]: Package functions as described.
>
>Pimple/Pimple.php compatibility class is unusable
>
>
>===== MUST items =====
>
>C/C++:
>[-]: Package does not contain kernel modules.
>[-]: Package contains no static executables.
>[-]: Development (unversioned) .so files in -devel subpackage, if present.
>     Note: Unversioned so-files in private %_libdir subdirectory (see
>     attachment). Verify they are not in ld path.
>[x]: Package does not contain any libtool archives (.la)
>[x]: Rpath absent or only used for internal libs.
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "MIT/X11 (BSD like)", "Unknown or generated". 1 files have unknown
>     license. Detailed output of licensecheck in
>     /home/extras/SPECS/review/1131731-php-pimple/licensecheck.txt
>[x]: Package requires other packages for directories it uses.
>     Note: No known owner of /usr/share/licenses
>[x]: Package must own all directories that it creates.
>     Note: Directories without known owners: /usr/share/licenses
>[x]: Package does not own files or directories owned by other packages.
>     Note: Dirs in package are owned also by: /usr/share/php/Pimple(php-
>     Pimple)
>[x]: %build honors applicable compiler flags or justifies otherwise.
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[x]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[!]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Useful -debuginfo package or justification otherwise.
>[x]: Package is not known to require an ExcludeArch tag.
>[-]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 20480 bytes in 3 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[!]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Uses parallel make %{?_smp_mflags} macro.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: No rpmlint messages.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note: phpCompatInfo version 3.3.0 static analyze results in
>     /home/extras/SPECS/review/1131731-php-pimple/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-pimple-3.0.0-2.fc20.x86_64.rpm
>          php-pimple-3.0.0-2.fc20.src.rpm
>php-pimple.src: W: spelling-error %description -l en_US usr -> use, us, user
>2 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-pimple
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-pimple (rpmlib, GLIBC filtered):
>    config(php-pimple)
>    libc.so.6()(64bit)
>    php(api)
>    php(language)
>    php(zend-abi)
>    php-spl
>    rtld(GNU_HASH)
>
>
>
>Provides
>--------
>php-pimple:
>    config(php-pimple)
>    php-Pimple
>    php-composer(pimple/pimple)
>    php-pimple
>    php-pimple(x86-64)
>
>
>
>Unversioned so-files
>--------------------
>php-pimple: /usr/lib64/php-zts/modules/pimple.so
>php-pimple: /usr/lib64/php/modules/pimple.so
>
>Source checksums
>----------------
>https://github.com/fabpot/Pimple/archive/876bf0899d01feacd2a2e83f04641e51350099ef/php-pimple-3.0.0-876bf0899d01feacd2a2e83f04641e51350099ef.tar.gz :
>  CHECKSUM(SHA256) this package     : cfa503b7ca1598081e29610fe6f0764526e4a139f44539467974a4ee03169802
>  CHECKSUM(SHA256) upstream package : cfa503b7ca1598081e29610fe6f0764526e4a139f44539467974a4ee03169802
>
>
>Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
>Command line :/usr/bin/fedora-review -b 1131731
>Buildroot used: fedora-20-x86_64
>Active plugins: Generic, PHP, Shell-api, C/C++
>Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
>Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Actions: View

Attachments on bug 1131731: 930739 | 930740 | 1058584 | 1058585