Attachment 935358 Details for Bug 1136833 – Proposed patch

[patch] Proposed patch

system-config-keyboard-git-master-missing-ok-button.patch (text/plain), 1.08 KB, created by Nils Philippsen on 2014-09-08 13:50:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nils Philippsen

Created: 2014-09-08 13:50:12 UTC

Size: 1.08 KB

patch

obsolete

>From aa1253f8f72e6373fea36d5cb40be72ae0de303e Mon Sep 17 00:00:00 2001
>From: Nils Philippsen <nils@redhat.com>
>Date: Mon, 8 Sep 2014 15:10:43 +0200
>Subject: [PATCH] only remove horizontal separator
>
>Newer versions of gtk+-2.x don't have the horizontal separator in the
>dialog widget. Don't remove the OK button accidentally.
>---
> src/keyboard_gui.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/src/keyboard_gui.py b/src/keyboard_gui.py
>index 680223f..e5d40e8 100644
>--- a/src/keyboard_gui.py
>+++ b/src/keyboard_gui.py
>@@ -250,8 +250,10 @@ class moduleClass(Module):
>         okButton.connect("clicked", self._okClicked)
> 
>         # Remove the hsep from the dialog.  It's ugly.
>+        # This is only relevant for older versions of gtk+-2.x.
>         hsep = self.mainWindow.get_children()[0].get_children()[0]
>-        self.mainWindow.get_children()[0].remove(hsep)
>+        if isinstance(hsep, gtk.HSeparator):
>+            self.mainWindow.get_children()[0].remove(hsep)
> 
>         self.mainWindow.vbox.pack_start(self.vbox)
>         self.mainWindow.show_all()
>-- 
>2.1.0
>

Actions: View | Diff

Attachments on bug 1136833: 934054 | 935358