Attachment 936274 Details for Bug 1140339 – Self-review

Self-review

review.txt (text/plain), 11.95 KB, created by Andy Lutomirski on 2014-09-10 17:40:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Lutomirski

Created: 2014-09-10 17:40:09 UTC

Size: 11.95 KB

patch

obsolete

>
>This is a review *template*. Besides handling the [ ]-marked tests you are
>also supposed to fix the template before pasting into bugzilla:
>- Add issues you find to the list of issues on top. If there isn't such
>  a list, create one.
>- Add your own remarks to the template checks.
>- Add new lines marked [!] or [?] when you discover new things not
>  listed by fedora-review.
>- Change or remove any text in the template which is plain wrong. In this
>  case you could also file a bug against fedora-review
>- Remove the "[ ] Manual check required", you will not have any such lines
>  in what you paste.
>- Remove attachments which you deem not really useful (the rpmlint
>  ones are mandatory, though)
>- Remove this text
>
>
>
>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[ ]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[ ]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 11 files have unknown license. Detailed output of
>     licensecheck in /home/luto/devel/virtme/fedora/virtme/licensecheck.txt
>[ ]: License file installed when any subpackage combination is installed.
>[ ]: Package contains no bundled libraries without FPC exception.
>[ ]: Changelog in prescribed format.
>[ ]: Sources contain only permissible code or content.
>[ ]: Package contains desktop file if it is a GUI application.
>[ ]: Development files must be in a -devel package
>[ ]: Package uses nothing in %doc for runtime.
>[ ]: Package consistently uses macros (instead of hard-coded directory names).
>[ ]: Package is named according to the Package Naming Guidelines.
>[ ]: Package does not generate any conflict.
>[ ]: Package obeys FHS, except libexecdir and /usr/target.
>[ ]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[ ]: Requires correct, justified where necessary.
>[ ]: Spec file is legible and written in American English.
>[ ]: Package contains systemd file(s) if in need.
>[ ]: Package is not known to require an ExcludeArch tag.
>[ ]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 61440 bytes in 3 files.
>[ ]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>Python:
>[ ]: Python eggs must not download any dependencies during the build process.
>[ ]: A package which is used by another package via an egg interface should
>     provide egg info.
>[ ]: Package meets the Packaging Guidelines::Python
>[x]: Package contains BR: python2-devel or python3-devel
>[x]: Binary eggs must be removed in %prep
>
>===== SHOULD items =====
>
>Generic:
>[ ]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[ ]: Final provides and requires are sane (see attachments).
>[ ]: Fully versioned dependency in subpackages if applicable.
>     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in virtme-
>     guest
>
>[amluto: I think this is a fedora-review bug -- this is a noarch package,
> so ${name}%{?_isa} won't work]
>
>[ ]: Package functions as described.
>[ ]: Latest version is packaged.
>[ ]: Package does not include license text files separate from upstream.
>[ ]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[ ]: Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: %check is present and all tests pass.
>[ ]: Packages should try to preserve timestamps of original installed files.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>
>
>Rpmlint
>-------
>
>[amluto: the non-executable script warnings are false alarms.  Fixed upstream:
>https://git.kernel.org/cgit/utils/kernel/virtme/virtme.git/commit/?id=a84a0b1d9fdb550bc5a1c6b129a982d25128cbc2
>]
>
>Checking: virtme-0.0.1-1.fc20.noarch.rpm
>          virtme-guest-0.0.1-1.fc20.noarch.rpm
>          virtme-0.0.1-1.fc20.src.rpm
>virtme.noarch: W: spelling-error Summary(en_US) Virtualize -> Visualizer, Virtual, Visualize
>virtme.noarch: W: spelling-error Summary(en_US) distro -> bistro, district
>virtme.noarch: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's
>virtme.noarch: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized
>virtme.noarch: W: spelling-error %description -l en_US rootfs -> roots, roofs, root's
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/architectures.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/cpiowriter.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/commands/run.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/mkinitramfs.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/guest_tools.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/virtmods.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/commands/configkernel.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/modfinder.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/qemu_helpers.py 0644L /usr/bin/python3
>virtme.noarch: W: no-manual-page-for-binary virtme-run
>virtme.noarch: W: no-manual-page-for-binary virtme-configkernel
>virtme-guest.noarch: W: spelling-error %description -l en_US initramfs -> ministrants
>virtme-guest.noarch: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems
>virtme-guest.noarch: W: spelling-error %description -l en_US rootfs -> roots, roofs, root's
>virtme-guest.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization
>virtme.src: W: spelling-error Summary(en_US) Virtualize -> Visualizer, Virtual, Visualize
>virtme.src: W: spelling-error Summary(en_US) distro -> bistro, district
>virtme.src: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's
>virtme.src: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized
>virtme.src: W: spelling-error %description -l en_US rootfs -> roots, roofs, root's
>3 packages and 0 specfiles checked; 9 errors, 16 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint virtme-guest virtme
>virtme-guest.noarch: W: spelling-error %description -l en_US initramfs -> ministrants
>virtme-guest.noarch: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems
>virtme-guest.noarch: W: spelling-error %description -l en_US rootfs -> roots, roofs, root's
>virtme-guest.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization
>virtme.noarch: W: spelling-error Summary(en_US) Virtualize -> Visualizer, Virtual, Visualize
>virtme.noarch: W: spelling-error Summary(en_US) distro -> bistro, district
>virtme.noarch: W: spelling-error Summary(en_US) rootfs -> roots, roofs, root's
>virtme.noarch: W: spelling-error %description -l en_US virtualized -> ritualized, visualized, actualized
>virtme.noarch: W: spelling-error %description -l en_US rootfs -> roots, roofs, root's
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/architectures.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/cpiowriter.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/commands/run.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/mkinitramfs.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/guest_tools.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/virtmods.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/commands/configkernel.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/modfinder.py 0644L /usr/bin/python3
>virtme.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/virtme/qemu_helpers.py 0644L /usr/bin/python3
>virtme.noarch: W: no-manual-page-for-binary virtme-run
>virtme.noarch: W: no-manual-page-for-binary virtme-configkernel
>2 packages and 0 specfiles checked; 9 errors, 11 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>virtme-guest (rpmlib, GLIBC filtered):
>    /bin/bash
>    /bin/sh
>    busybox
>    iproute
>    util-linux
>
>virtme (rpmlib, GLIBC filtered):
>    /usr/bin/python3
>    python(abi)
>    python3-setuptools
>    virtme-guest
>
>
>
>Provides
>--------
>virtme-guest:
>    virtme-guest
>
>virtme:
>    virtme
>
>
>
>Source checksums
>----------------
>https://www.kernel.org/pub/linux/utils/kernel/virtme/releases/virtme-0.0.1.tar.xz :
>  CHECKSUM(SHA256) this package     : 306e79f1bacf3723515dc9f24a702fec0a4157d2b50b35fb4bed78d67d17d16a
>  CHECKSUM(SHA256) upstream package : 306e79f1bacf3723515dc9f24a702fec0a4157d2b50b35fb4bed78d67d17d16a
>
>
>Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
>Command line :/usr/bin/fedora-review -rn /home/luto/rpmbuild/SRPMS/virtme-0.0.1-1.fc20.src.rpm
>Buildroot used: fedora-20-x86_64
>Active plugins: Python, Generic, Shell-api
>Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
>Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Actions: View

Attachments on bug 1140339: 936274