Attachment 936277 Details for Bug 1133686 – bugfix for starting dhclient

[patch] bugfix for starting dhclient

0001-v1.1-for-dhclient-use-g_spawn_sync.patch (text/plain), 1.54 KB, created by Gene Czarcinski on 2014-09-10 17:56:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gene Czarcinski

Created: 2014-09-10 17:56:54 UTC

Size: 1.54 KB

patch

obsolete

>From 4c8b769628d78c39cf522e020b4cc95d8eb08878 Mon Sep 17 00:00:00 2001
>From: Gene Czarcinski <gczarcinski@ec.rr.com>
>Date: Wed, 10 Sep 2014 07:12:20 -0400
>Subject: [PATCH 1/2] v1.1 for dhclient use g_spawn_sync()
>Content-Type: text/plain; charset="utf-8"
>Content-Transfer-Encoding: 8bit
>
>This patch addresses problem RHBZ #1133686.
>
>For some (unknown to me) reason, g_spawn_async() is not
>starting dhclient so that a dhcp NIC can be configured.
>However, simply using g_spawn_sync() works.  This was the
>only use of g_spawn_async().
>
>Note: There is no problem using sync instead of async since dhclient will
>disconnect and put itself in the background once the network is started.
>---
> libvirt-sandbox/libvirt-sandbox-init-common.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/libvirt-sandbox/libvirt-sandbox-init-common.c b/libvirt-sandbox/libvirt-sandbox-init-common.c
>index e5f8af0..49baa5c 100644
>--- a/libvirt-sandbox/libvirt-sandbox-init-common.c
>+++ b/libvirt-sandbox/libvirt-sandbox-init-common.c
>@@ -113,10 +113,8 @@ static gboolean start_dhcp(const gchar *devname, GError **error)
> {
>     const gchar *argv[] = { "/sbin/dhclient", "--no-pid", devname, NULL };
> 
>-    if (!g_spawn_async(NULL, (gchar**)argv, NULL,
>-                       G_SPAWN_STDOUT_TO_DEV_NULL |
>-                       G_SPAWN_STDERR_TO_DEV_NULL,
>-                       NULL, NULL, NULL, error))
>+    if (!g_spawn_sync(NULL, (gchar**)argv, NULL, 0,
>+                      NULL, NULL, NULL, NULL, NULL, error))
>         return FALSE;
> 
>     return TRUE;
>-- 
>1.9.3
>

Actions: View | Diff

Attachments on bug 1133686: 936277 | 936278