Attachment 936323 Details for Bug 1140397 – proposed patch

[patch] proposed patch

koji-downloadlogs.patch (text/plain), 1.17 KB, created by Honza Horak on 2014-09-10 20:49:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Honza Horak

Created: 2014-09-10 20:49:52 UTC

Size: 1.17 KB

patch

obsolete

>Koji's download-logs does not seem to work. The task id is found, but nothing
>is download. Downloading tasks works fine.
>
>Reproducer:
>$> koji download-logs --nvr some-recent-build-1.0-1.fc21
>Using task ID: 12345678
>
>No new files found.
>
>diff -up koji-1.9.0/cli/koji.downlog koji-1.9.0/cli/koji
>--- koji-1.9.0/cli/koji.downlog	2014-09-10 22:38:14.824612334 +0200
>+++ koji-1.9.0/cli/koji	2014-09-10 22:38:19.702612559 +0200
>@@ -5953,13 +5953,12 @@ def anon_handle_download_logs(options, s
>             assert binfo['task_id'], binfo
>             arg = binfo['task_id']
>             sys.stdout.write("Using task ID: %s\n" % arg)
>-        else:
>-            try:
>-                task_id = int(arg)
>-            except ValueError:
>-                error(_("Task id must be number: %r") % task_id)
>-                continue
>-            save_logs(task_id, suboptions.match, suboptions.dir, suboptions.recurse)
>+        try:
>+            task_id = int(arg)
>+        except ValueError:
>+            error(_("Task id must be number: %r") % task_id)
>+            continue
>+        save_logs(task_id, suboptions.match, suboptions.dir, suboptions.recurse)
> 
> 
> def anon_handle_wait_repo(options, session, args):

Actions: View | Diff

Attachments on bug 1140397: 936323