Attachment 938082 Details for Bug 1142303 – Proposed fix

[patch] Proposed fix

0001-Don-t-die-if-manifind-visits-symlinked-directory-aga.patch (text/plain), 1.62 KB, created by Petr Pisar on 2014-09-16 15:34:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Petr Pisar

Created: 2014-09-16 15:34:51 UTC

Size: 1.62 KB

patch

obsolete

>From e650e2e803340e193fe8dec4a72c273aa8ec46ac Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
>Date: Tue, 16 Sep 2014 17:11:59 +0200
>Subject: [PATCH] Don't die if manifind() visits symlinked directory again
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Some CPAN distributions, e.g. File-DirCompare-0.7, contains symbolic
>links to directories. File::Find::Find(follow=>1) introduced by
>commit:
>
>commit 686bd545e608c7506ff5a14271feca8457256077
>Author: Chris 'BinGOs' Williams <chris@bingosnet.co.uk>
>Date:   Sun Aug 31 14:08:37 2014 +0100
>
>    [RT #21283] manifind() does not follow symbolic links
>
>died when processing such a directory for second time.
>
>This patch allows to visit and report such directories and their
>content multiple times (except cycles). This solution instead of
>ignoring them was chosen to prevent from getting only one and randomly
>selected traversal path to be reported.
>
><https://github.com/Perl-Toolchain-Gang/ExtUtils-Manifest/issues/5>
>
>Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com>
>---
> lib/ExtUtils/Manifest.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/ExtUtils/Manifest.pm b/lib/ExtUtils/Manifest.pm
>index 6e0e838..6cfa489 100644
>--- a/lib/ExtUtils/Manifest.pm
>+++ b/lib/ExtUtils/Manifest.pm
>@@ -195,7 +195,7 @@ sub manifind {
>     # $File::Find::name is unavailable.
>     # Also, it's okay to use / here, because MANIFEST files use Unix-style
>     # paths.
>-    find({wanted => $wanted, follow => 1},
>+    find({wanted => $wanted, follow_fast => 1},
> 	 $Is_MacOS ? ":" : ".");
> 
>     return $found;
>-- 
>1.9.3
>

Actions: View | Diff

Attachments on bug 1142303: 938082