Attachment 938468 Details for Bug 968147 – [RHEL7.1 PATCH 3/4] x86/smpboot: Log error on secondary CPU wakeup failure at ERR level

[patch] [RHEL7.1 PATCH 3/4] x86/smpboot: Log error on secondary CPU wakeup failure at ERR level

0003-x86-smpboot-Log-error-on-secondary-CPU-wakeup-failur.patch (text/plain), 1.45 KB, created by Igor Mammedov on 2014-09-17 12:56:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Igor Mammedov

Created: 2014-09-17 12:56:13 UTC

Size: 1.45 KB

patch

obsolete

>From 9ba734b1d89ba78f0f76970465700ece1480647f Mon Sep 17 00:00:00 2001
>From: Igor Mammedov <imammedo@redhat.com>
>Date: Thu, 5 Jun 2014 15:42:44 +0200
>Subject: [RHEL7.1 PATCH 3/4] x86/smpboot: Log error on secondary CPU wakeup failure at
> ERR level
>
>BZ: https://bugzilla.redhat.com/show_bug.cgi?id=968147
>Brew: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=7981610
>Upstream: feef1e8ecbadf24f8e6829c935df8683cabae41b
>
>If system is running without debug level logging,
>it will not log error if do_boot_cpu() failed to
>wakeup AP. It may lead to silent AP bringup
>failures at boot time.
>Change message level to KERN_ERR to make error
>visible to user as it's done on other architectures.
>
>Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>Acked-by: Toshi Kani <toshi.kani@hp.com>
>Cc: Thomas Gleixner <tglx@linutronix.de>
>Link: http://lkml.kernel.org/r/1401975765-22328-3-git-send-email-imammedo@redhat.com
>Signed-off-by: Ingo Molnar <mingo@kernel.org>
>---
> arch/x86/kernel/smpboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
>index e210ab7..9ba8ede 100644
>--- a/arch/x86/kernel/smpboot.c
>+++ b/arch/x86/kernel/smpboot.c
>@@ -898,7 +898,7 @@ int native_cpu_up(unsigned int cpu, struct task_struct *tidle)
> 
> 	err = do_boot_cpu(apicid, cpu, tidle);
> 	if (err) {
>-		pr_debug("do_boot_cpu failed %d\n", err);
>+		pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu);
> 		return -EIO;
> 	}
> 
>-- 
>1.8.3.1
>

Actions: View | Diff

Attachments on bug 968147: 754159 | 870935 | 936529 | 938465 | 938466 | 938468 | 938469