Attachment 940788 Details for Bug 1145325 – Fix LTP recvfrom01 syscall test case 4

Fix LTP recvfrom01 syscall test case 4

ltp.patch (text/plain), 1.21 KB, created by Chuck Ebbert on 2014-09-24 14:16:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chuck Ebbert

Created: 2014-09-24 14:16:11 UTC

Size: 1.21 KB

patch

obsolete

>The recvfrom01 testcase had reported failures on 3.17-rc [1].
>
>Three of those failures were invalid assumptions about kernel behavior
>with every possible flag set. [2]
>
>The fourth failure is because arguments are mixed up in testcase 4,
>making it identical to testcase 6. Fix that.
>
>Also fix indentation that made it harder to spot this bug.
>
>[1] https://bugzilla.redhat.com/show_bug.cgi?id=1145325
>[2] http://marc.info/?t=141148149900006&r=1&w=2
>
>Signed-off-by: Chuck Ebbert <cebbert.lkml@gmail.com>
>
>--- a/testcases/kernel/syscalls/recvfrom/recvfrom01.c
>+++ b/testcases/kernel/syscalls/recvfrom/recvfrom01.c
>@@ -105,7 +105,7 @@
> 		    0, ENOTSOCK, setup1, cleanup1, "invalid socket buffer"},
> /* 4 */
> 	{
>-	PF_INET, SOCK_STREAM, 0, (void *)buf, sizeof(buf), -1,
>+	PF_INET, SOCK_STREAM, 0, (void *)buf, -1, 0,
> 		    (struct sockaddr *)&from, &fromlen,
> 		    -1, EINVAL, setup2, cleanup1, "invalid socket length"},
> /* 5 */
>@@ -115,7 +115,7 @@
> 		    -1, EFAULT, setup1, cleanup1, "invalid recv buffer"},
> /* 6 */
> 	{
>-PF_INET, SOCK_STREAM, 0, (void *)buf, sizeof(buf), -1,
>+	PF_INET, SOCK_STREAM, 0, (void *)buf, sizeof(buf), -1,
> 		    (struct sockaddr *)&from, &fromlen,
> 		    -1, EINVAL, setup1, cleanup1, "invalid flags set"},};
>

Actions: View

Attachments on bug 1145325: 940788