Attachment 941141 Details for Bug 1146618 – Patch to fix the bug described

Patch to fix the bug described

always-allow-setting-max-downtime.patch (text/plain), 990 bytes, created by Chris St. Pierre on 2014-09-25 15:37:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris St. Pierre

Created: 2014-09-25 15:37:12 UTC

Size: 990 bytes

patch

obsolete

>commit d217326c2a6f4b28192d0894b93d3238f8601fe8
>Author: Chris St. Pierre <chris.a.st.pierre@gmail.com>
>Date:   Thu Sep 25 10:27:15 2014 -0500
>
>    Allow setting migration max downtime any time
>    
>    This removes the artificial and unnecessary restriction that
>    virDomainSetMaxDowntime() only be called while a migration is in
>    progress.
>
>diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>index 117138a..10efab8 100644
>--- a/src/qemu/qemu_driver.c
>+++ b/src/qemu/qemu_driver.c
>@@ -12023,12 +12023,6 @@ qemuDomainMigrateSetMaxDowntime(virDomainPtr dom,
> 
>     priv = vm->privateData;
> 
>-    if (priv->job.asyncJob != QEMU_ASYNC_JOB_MIGRATION_OUT) {
>-        virReportError(VIR_ERR_OPERATION_INVALID,
>-                       "%s", _("domain is not being migrated"));
>-        goto endjob;
>-    }
>-
>     VIR_DEBUG("Setting migration downtime to %llums", downtime);
>     qemuDomainObjEnterMonitor(driver, vm);
>     ret = qemuMonitorSetMigrationDowntime(priv->mon, downtime);

Actions: View

Attachments on bug 1146618: 941141