Attachment 942920 Details for Bug 1141996 – upstream patch to fix an issue (caused by the previously attached patch) in the Windows Smbfs volume driver

[patch] upstream patch to fix an issue (caused by the previously attached patch) in the Windows Smbfs volume driver

cve-2014-3641-master-juno-windows-smbfs.patch (text/plain), 1.37 KB, created by Murray McAllister on 2014-10-01 05:33:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Murray McAllister

Created: 2014-10-01 05:33:17 UTC

Size: 1.37 KB

patch

obsolete

>From 38a222097337ea30d142b0b49ecf6637e8809001 Mon Sep 17 00:00:00 2001
>From: Lucian Petrut <lpetrut@cloudbasesolutions.com>
>Date: Tue, 30 Sep 2014 11:58:22 +0300
>Subject: [PATCH] Windows SMBFS: Handle volume_name in _qemu_img_info
>
>The volume_name is now parsed to the _qemu_img_info wrapper. As
>this method is not prone to security issues because this driver
>does not support raw images (at least not yet), we don't have to
>perform any checks on the backing image file path.
>
>Thus, this method simply ignores this argument that will be parsed
>by the base class methods.
>---
> cinder/volume/drivers/windows/smbfs.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/cinder/volume/drivers/windows/smbfs.py b/cinder/volume/drivers/windows/smbfs.py
>index 275e079..c2c0798 100644
>--- a/cinder/volume/drivers/windows/smbfs.py
>+++ b/cinder/volume/drivers/windows/smbfs.py
>@@ -135,7 +135,7 @@ class WindowsSmbfsDriver(smbfs.SmbfsDriver):
>         backing_file_path = os.path.join(image_dir, backing_file)
>         self.vhdutils.reconnect_parent(image, backing_file_path)
> 
>-    def _qemu_img_info(self, path):
>+    def _qemu_img_info(self, path, volume_name=None):
>         # This code expects to deal only with relative filenames.
>         # As this method is needed by the upper class and qemu-img does
>         # not fully support vhdx images, for the moment we'll use Win32 API
>-- 
>1.8.3.2
>

Actions: View | Diff

Attachments on bug 1141996: 942918 | 942919 | 942920