Attachment 943022 Details for Bug 1145751 – RHEL PATCH 3/2

[patch] RHEL PATCH 3/2

0003-ACPI-container-Fix-error-code-path-in-container_devi.patch (text/plain), 1.37 KB, created by Prarit Bhargava on 2014-10-01 11:48:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Prarit Bhargava

Created: 2014-10-01 11:48:45 UTC

Size: 1.37 KB

patch

obsolete

>From cdfc8fe77ec22145da45c7ed900aacb394a51883 Mon Sep 17 00:00:00 2001
>From: Prarit Bhargava <prarit@redhat.com>
>Date: Thu, 25 Sep 2014 08:08:14 -0400
>Subject: [3/6] ACPI / container: Fix error code path in
> container_device_attach()
>
>commit 0f6aa09e40c38d734f5d70762056116ca4a76126
>Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>Date:   Wed Feb 12 00:52:49 2014 +0100
>
>    ACPI / container: Fix error code path in container_device_attach()
>
>    To avoid leaking memory on errors from device_register(), do a
>    put_device() on the device object in question in the error code
>    path of container_device_attach().
>
>    Fixes: caa73ea158de (ACPI / hotplug / driver core: Handle containers in a special way)
>    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>    Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>---
> drivers/acpi/container.c |    5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
>index 0b6ae6e..368f9dd 100644
>--- a/drivers/acpi/container.c
>+++ b/drivers/acpi/container.c
>@@ -79,9 +79,10 @@ static int container_device_attach(struct acpi_device *adev,
> 	ACPI_COMPANION_SET(dev, adev);
> 	dev->release = acpi_container_release;
> 	ret = device_register(dev);
>-	if (ret)
>+	if (ret) {
>+		put_device(dev);
> 		return ret;
>-
>+	}
> 	adev->driver_data = dev;
> 	return 1;
> }
>-- 
>1.7.9.3
>

Actions: View | Diff

Attachments on bug 1145751: 941540 | 941541 | 941542 | 941543 | 941544 | 941545 | 943020 | 943021 | 943022 | 943023 | 943024 | 943025 | 975178 | 975179