Attachment 943698 Details for Bug 1037219 – patch + spec changeset

[patch] patch + spec changeset

0001-fix-s-printf-calls-so-format-security-works.patch (text/plain), 2.55 KB, created by Marcin Juszkiewicz on 2014-10-03 10:46:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcin Juszkiewicz

Created: 2014-10-03 10:46:06 UTC

Size: 2.55 KB

patch

obsolete

>From 996d9548e4c3baffde3fa3ca32294c52da6f1a62 Mon Sep 17 00:00:00 2001
>From: Marcin Juszkiewicz <mjuszkiewicz@redhat.com>
>Date: Fri, 3 Oct 2014 12:34:47 +0200
>Subject: [PATCH] fix (s)printf calls so -format-security works
>
>---
> nightfall-format-security.patch | 17 +++++++++++++++++
> nightfall.spec                  |  7 ++++++-
> 2 files changed, 23 insertions(+), 1 deletion(-)
> create mode 100644 nightfall-format-security.patch
>
>diff --git a/nightfall-format-security.patch b/nightfall-format-security.patch
>new file mode 100644
>index 0000000..bcc06f6
>--- /dev/null
>+++ b/nightfall-format-security.patch
>@@ -0,0 +1,17 @@
>+Index: nightfall-1.62/LightChiMap.c
>+===================================================================
>+--- nightfall-1.62.orig/LightChiMap.c
>++++ nightfall-1.62/LightChiMap.c
>+@@ -216,10 +216,10 @@ int ChiMap()
>+ 
>+     sprintf(message, _("Column %5d of %5d finished\n"), i+1, _CHI_SCANS_);
>+     if (Flags.debug[BUSY] == ON || Flags.debug[VERBOSE] == ON)
>+-      printf(message);
>++      printf("%s", message);
>+ #ifdef _WITH_GTK
>+     if (Flags.interactive == ON) { 
>+-      sprintf(message, _("Column %5d of %5d finished"), i+1, _CHI_SCANS_);
>++      sprintf("%s", message, _("Column %5d of %5d finished"), i+1, _CHI_SCANS_);
>+       my_appbar_push(message);
>+       sleep (1);
>+     }
>diff --git a/nightfall.spec b/nightfall.spec
>index b67d303..0b76222 100644
>--- a/nightfall.spec
>+++ b/nightfall.spec
>@@ -1,6 +1,6 @@
> Name:		nightfall
> Version:	1.62
>-Release:	17%{?dist}
>+Release:	18%{?dist}
> Summary:	Nightfall is an astronomy application for emulation of eclipsing stars
> 
> License:	GPLv2+
>@@ -10,6 +10,7 @@ Source0:	http://www.la-samhna.de/%{name}/%{name}-%{version}.tar.gz
> Source1:	nightfall.desktop
> Patch0:		nightfall-1.62-fixmakefile.patch
> Patch1:		nightfall-1.62-optflags.patch
>+Patch2:     nightfall-format-security.patch
> 
> BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> BuildRequires:	gtk2-devel, desktop-file-utils
>@@ -27,6 +28,7 @@ It is, however, not able to fry your breakfast egg on your harddisk.
> %setup -q
> %patch0 -p2 -b .makefile
> %patch1 -p1 -b .optflags
>+%patch2 -p1
> 
> %build
> %configure --with-gnuplot --enable-gnome
>@@ -50,6 +52,9 @@ rm -rf ${RPM_BUILD_ROOT}
> %{_datadir}/applications/*nightfall.desktop
> 
> %changelog
>+* Fri Oct 03 2014 Marcin Juszkiewicz <mjuszkiewicz@redhat.com> - 1.62-18
>+- fix (s)printf calls so -format-security works
>+
> * Sun Aug 17 2014 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.62-17
> - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild
> 
>-- 
>2.1.0
>

Actions: View | Diff

Attachments on bug 1037219: 943698