Attachment 946770 Details for Bug 1151855 – review.txt

review.txt

review.txt (text/plain), 7.86 KB, created by Remi Collet on 2014-10-14 09:05:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2014-10-14 09:05:44 UTC

Size: 7.86 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>[!]: Package must own all directories that it creates.
>     Note: Directories without known owners:
>     /usr/share/pear/Date/Holidays/Filter/Austria
>
>[!]: Requires correct, justified where necessary.
>  => missing php-date (see phpci.log)
>
>[!]: Each %files section contains %defattr if rpm < 4.4
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[!]: Buildroot is not present
>     Note: Buildroot: present but not needed
>[!]: Package has no %clean section with rm -rf %{buildroot} (or
>  => For consistency, if EPEL-5 is planed, add rm -rf ... in %install
>  if EPEL-5 is not planed, clean the others
>
>[!]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>  => PHP License is mandatory per license term (BSD like).
>  => File a upstream bug + add link to this bug
>  => You can add the file to the package (link in the headers)
>
>About
>        # pear.php.net has interesting packaging habits!
>        %{__tar} -xif %{SOURCE0}
>  => This is not a pear habit, but a corrupted archive (known bug with old Archive_Tar version)
>  => File a bug upstream and add link in the spec
>
>  
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "PHP (v3.0)", "Unknown or generated". 1 files have unknown license.
>     Detailed output of licensecheck in /home/extras/SPECS/review/1151855-php-
>     pear-Date-Holidays-Austria/licensecheck.txt
>[x]: Package requires other packages for directories it uses.
>     Note: No known owner of /usr/share/pear/Date/Holidays/Filter/Austria
>[!]: Package must own all directories that it creates.
>     Note: Directories without known owners:
>     /usr/share/pear/Date/Holidays/Filter/Austria
>[-]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[!]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[!]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[-]: Package is not known to require an ExcludeArch tag.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Package does not own files or directories owned by other packages.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package do not use a name that already exist
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 0 bytes in 0 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[!]: Buildroot is not present
>     Note: Buildroot: present but not needed
>[!]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: %clean present but not required
>[!]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[-]: Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Dist tag is present (not strictly required in GL).
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>
>PHP:
>[x]: Run phpci static analyze on all php files.
>     Note: phpCompatInfo version 3.4.0 static analyze results in
>     /home/extras/SPECS/review/1151855-php-pear-Date-Holidays-
>     Austria/phpci.log
>
>
>Rpmlint
>-------
>Checking: php-pear-Date-Holidays-Austria-0.1.5-1.fc19.noarch.rpm
>          php-pear-Date-Holidays-Austria-0.1.5-1.fc19.src.rpm
>php-pear-Date-Holidays-Austria.noarch: W: no-documentation
>2 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-pear-Date-Holidays-Austria
>php-pear-Date-Holidays-Austria.noarch: W: no-documentation
>1 packages and 0 specfiles checked; 0 errors, 1 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-pear-Date-Holidays-Austria (rpmlib, GLIBC filtered):
>    /bin/sh
>    /usr/bin/pear
>    php-pear(Date_Holidays)
>    php-pear(PEAR)
>
>
>
>Provides
>--------
>php-pear-Date-Holidays-Austria:
>    php-pear(Date_Holidays_Austria)
>    php-pear-Date-Holidays-Austria
>
>
>
>Source checksums
>----------------
>http://pear.php.net/get/Date_Holidays_Austria-0.1.5.tgz :
>  CHECKSUM(SHA256) this package     : f72f18a4b56fcdf93c8e9430057b51938fe9c73e45ac9468b15253ed0e150548
>  CHECKSUM(SHA256) upstream package : f72f18a4b56fcdf93c8e9430057b51938fe9c73e45ac9468b15253ed0e150548
>
>
>Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
>Command line :/usr/bin/fedora-review -b 1151855
>Buildroot used: fedora-19-x86_64
>Active plugins: Generic, PHP, Shell-api
>Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
>Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Actions: View

Attachments on bug 1151855: 946768 | 946770