Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 948194 Details for
Bug 1153315
Multiple bugs in NetworkManager-l2tp
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Make the ipsec.secrets file not world-readable
nm-l2tp-hide-secrets (text/plain), 1.33 KB, created by
Alan Stern
on 2014-10-18 22:16:12 UTC
(
hide
)
Description:
Make the ipsec.secrets file not world-readable
Filename:
MIME Type:
Creator:
Alan Stern
Created:
2014-10-18 22:16:12 UTC
Size:
1.33 KB
patch
obsolete
>When nm-l2tp-service creates a temporary file to hold the secret key >for an IPsec connection, the file it creates is world-readable! Even >though the file persists for a short time, this is clearly a security >risk. > >This patch changes the umask so that the temp file will be accessible >only to root. > > src/nm-l2tp-service.c | 4 ++++ > 1 file changed, 4 insertions(+) > >Index: NetworkManager-l2tp-0.9.8.7/src/nm-l2tp-service.c >=================================================================== >--- NetworkManager-l2tp-0.9.8.7.orig/src/nm-l2tp-service.c >+++ NetworkManager-l2tp-0.9.8.7/src/nm-l2tp-service.c >@@ -888,6 +888,7 @@ nm_l2tp_start_ipsec(NML2tpPlugin *plugin > char session_name[128]; > guint sys=0; > FILE *fp; >+ mode_t orig_umask; > > if (!(ipsec_binary=nm_find_ipsec())) { > g_set_error (error, >@@ -938,7 +939,9 @@ nm_l2tp_start_ipsec(NML2tpPlugin *plugin > return FALSE; > } > >+ orig_umask = umask(0077); > if(!(fp=fopen("/etc/ipsec.secrets","w"))) { >+ umask(orig_umask); > rename(tmp_secrets, "/etc/ipsec.secrets"); > g_set_error (error, > NM_VPN_PLUGIN_ERROR, >@@ -957,6 +960,7 @@ nm_l2tp_start_ipsec(NML2tpPlugin *plugin > if(!value)value=""; > fprintf(fp, ": PSK \"%s\"\n",value); > fclose(fp); >+ umask(orig_umask); > > sys += system("PATH=\"/sbin:/usr/sbin:/usr/local/sbin:$PATH\" ipsec secrets"); > sys += system(cmd11);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1153315
:
947288
|
947289
|
948191
|
948193
| 948194 |
948195
|
948196
|
948197