Bug 2041100 - Review Request: cryfs - CryFS encrypts your files, so you can safely store them anywhere.
Summary: Review Request: cryfs - CryFS encrypts your files, so you can safely store th...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-01-15 23:15 UTC by Onuralp Sezer
Modified: 2023-05-07 08:11 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-07 08:11:24 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Onuralp Sezer 2022-01-15 23:15:28 UTC 
Spec URL: https://pagure.io/cryfs_rpm/raw/main/f/cryfs.spec
SRPM URL: https://pagure.io/cryfs_rpm/blob/main/f/cryfs-0.11.1-1.fc35.src.rpm
Description: CryFS encrypts your files, so you can safely store them anywhere
Fedora Account System Username: thunderbirdtr
Comment 1 Neal Gompa 2022-01-17 19:05:46 UTC 
Taking review.
Comment 2 Neal Gompa 2022-01-22 17:39:12 UTC 
Initial review:

> BuildRequires:  boost-atomic
> BuildRequires:  boost-chrono
> BuildRequires:  boost-filesystem
> BuildRequires:  boost-program-options
> BuildRequires:  boost-system
> BuildRequires:  boost-thread

You just need to "BuildRequires:  boost-devel" here. These BRs are completely wrong (since they're only runtime libraries).
Comment 3 Onuralp SEZER 2022-01-22 18:30:59 UTC 
I removed all of them and add a patch for "un-versioned" python command and sent a PR to upstream.
Comment 4 Neal Gompa 2022-01-22 19:14:57 UTC 
Review notes:

[x]: Package follows Fedora Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.
Comment 5 Gwyn Ciesla 2022-01-24 16:58:03 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/cryfs
Comment 6 Andrey Brusnik 2022-05-10 20:15:46 UTC 
Looks like cryfs package broken in Fedora Linux 36 repositories. Even `cryfs -h` fails with error:

cryfs: symbol lookup error: cryfs: undefined symbol: _ZN6spdlog5sinks15basic_file_sinkISt5mutexEC1ERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEb


Related: https://github.com/mpobaschnig/Vaults/issues/41
Comment 7 Package Review 2023-05-07 08:11:24 UTC 
Package is now in repositories, closing review.
Note You need to log in before you can comment on or make changes to this bug.