Bug 634902 - rpm spec template is out-of-date
Summary: rpm spec template is out-of-date
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: vim
Version: 6.1
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Karsten Hopp
QA Contact: Petr Šplíchal
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-09-17 10:33 UTC by Máirín Duffy
Modified: 2016-06-01 01:40 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 825679 (view as bug list)
Environment:
Last Closed: 2012-04-05 08:24:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0454 0 normal SHIPPED_LIVE vim bug fix update 2012-04-05 12:22:05 UTC

Description Máirín Duffy 2010-09-17 10:33:25 UTC
Description of problem:

the spec file template in vim is out-of-date.

for example:

%clean
#rm -rf $RPM_BUILD_ROOT

-This section is no-longer needed.

%install
rm -rf $RPM_BUILD_ROOT

-The rm -rf line is no longer needed.

make install DESTDIR=$RPM_BUILD_ROOT

- the use of $-style macro is out-of-date and also inconsistent with the %{}-style macro further up in the template
- should probably be instead: make DESTDIR=%{buildroot} install

Comment 9 RHEL Program Management 2011-08-19 18:08:49 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 12 Karsten Hopp 2012-02-17 14:14:05 UTC
I'll fix only the RPM_BUILD_ROOT macro. RHEL6 rpmlint complains when the
cleanup lines get removed:
xxx.spec: W: no-cleaning-of-buildroot %install
xxx.spec: W: no-cleaning-of-buildroot %clean
xxx.spec: W: no-%clean-section

Comment 15 errata-xmlrpc 2012-04-05 08:24:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0454.html


Note You need to log in before you can comment on or make changes to this bug.