Back to bug 1044122

Who When What Removed Added
Jan Pokorný [poki] 2013-12-17 21:04:13 UTC CC pdemmers
Jan Pokorný [poki] 2013-12-17 21:05:32 UTC Summary reboot_now function of reboot module in ricci RPC is racy and cause reboot loop reboot_now function of reboot module in ricci RPC can lead to reboot loop
Fabio Massimo Di Nitto 2014-02-28 12:13:08 UTC Priority unspecified low
CC fdinitto
Assignee cfeist jpokorny
Severity unspecified low
Jan Pokorný [poki] 2014-03-02 19:22:40 UTC Status NEW ASSIGNED
Radek Steiger 2014-03-12 15:00:46 UTC CC rsteiger
John Skeoch 2014-06-18 07:07:58 UTC CC pdemmers joallen
Jan Pokorný [poki] 2014-06-20 18:35:28 UTC Status ASSIGNED POST
Jan Pokorný [poki] 2014-06-20 19:49:21 UTC Attachment #910869 Attachment is obsolete 0 1
Jan Pokorný [poki] 2014-06-20 19:50:01 UTC Comment 8 is private 1 0
Jan Pokorný [poki] 2014-06-23 15:39:00 UTC Status POST MODIFIED
Fixed In Version ricci-0.16.2-73.el6
errata-xmlrpc 2014-06-23 15:48:21 UTC Status MODIFIED ON_QA
Jan Pokorný [poki] 2014-07-02 17:56:09 UTC Status ON_QA POST
Jan Pokorný [poki] 2014-07-02 19:06:29 UTC Doc Text Cause:
Time window allowing for remotely invoked reboot task not being
considered finished if the system reboot is performed faster than
ricci worker gets a chance to mark the successful completion.

Consequence:
Chance that ricci will cause an unintentional reboot loop
preventing from normal use of the machine.

Fix:
Now the task is removed from any further scheduling before
the reboot process is initiated, and possible failure is reflected
later on.

Result:
Ricci won't cause a reboot loop because of the said circumstances.
Jan Pokorný [poki] 2014-07-04 17:55:08 UTC Status POST MODIFIED
Fixed In Version ricci-0.16.2-73.el6 ricci-0.16.2-74.el6
Jan Pokorný [poki] 2014-07-04 18:19:34 UTC Doc Text Cause:
Time window allowing for remotely invoked reboot task not being
considered finished if the system reboot is performed faster than
ricci worker gets a chance to mark the successful completion.

Consequence:
Chance that ricci will cause an unintentional reboot loop
preventing from normal use of the machine.

Fix:
Now the task is removed from any further scheduling before
the reboot process is initiated, and possible failure is reflected
later on.

Result:
Ricci won't cause a reboot loop because of the said circumstances.
Cause:
Time window allowing for remotely invoked reboot task not being
considered finished if the system reboot is performed faster than
ricci worker gets a chance to mark the successful completion.
Also, proceeded files left behind if ricci restart (caused, e.g.,
by reboot) occurred during processing respective batches of tasks.

Consequence:
Chance that ricci will cause an unintentional reboot loop
preventing from normal use of the machine.
Also, unnecessary clutter in the directory with batches to proceed.

Fix:
Now the task is refrained from any further scheduling before
the reboot process is initiated with possible ad-hoc failure
propagation. Also the problem with stale files left behind
is addressed with each such removed file reported to system log.

Result:
Ricci won't cause a reboot loop because of the said circumstances,
nor it will leave stale files from finished batch processing behind
needlessly.
Summary reboot_now function of reboot module in ricci RPC can lead to reboot loop Batch processing vs. reboot: fix possible reboot loop and the clutter from when batch processing gets interrupted
Jan Pokorný [poki] 2014-07-04 18:22:15 UTC Status MODIFIED ON_QA
Radek Steiger 2014-08-25 19:23:04 UTC Status ON_QA VERIFIED
errata-xmlrpc 2014-10-14 07:29:48 UTC Status VERIFIED CLOSED
Resolution --- ERRATA
Last Closed 2014-10-14 03:29:48 UTC

Back to bug 1044122