Back to bug 1100571
| Who | When | What | Removed | Added |
|---|---|---|---|---|
| Atin Mukherjee | 2014-05-23 06:54:19 UTC | Status | NEW | ON_QA |
| Fixed In Version | glusterfs-3.6.0.3-1.el6rhs | |||
| Assignee | vbellur | amukherj | ||
| Doc Text | barrier_fsync was not getting hit when fsync call is issued from the application over NFS mount. Investigation reveals that NFS doesn't send an explicit fsync call to the glusterfs server, however NFS converts it with a stable write with O_DSYNC flag, so for a fsync call over NFS mount point, barrier feature always needs to check for writev and its correspoding flags. So to meet all the coditions of write with O_SYNC and fsync getting blocked when barrier is enabled the check has been modified with following: if (!((flags | fd->flags) & (O_SYNC | O_DSYNC))) Point to be noted here is we need to check both fd's flag and the explicit flag as for NFS write fd->flags is 0. | |||
| Target Milestone | --- | RHS 3.0 | ||
| SATHEESARAN | 2014-05-23 07:04:16 UTC | QA Contact | sdharane | sasundar |
| Nagaprasad Sathyanarayana | 2014-05-23 08:14:38 UTC | Priority | unspecified | high |
| CC | nsathyan | |||
| Sudhir D | 2014-05-27 08:52:29 UTC | CC | sdharane | |
| SATHEESARAN | 2014-05-30 04:55:37 UTC | Status | ON_QA | VERIFIED |
| Atin Mukherjee | 2014-05-30 07:14:33 UTC | Doc Text | barrier_fsync was not getting hit when fsync call is issued from the application over NFS mount. Investigation reveals that NFS doesn't send an explicit fsync call to the glusterfs server, however NFS converts it with a stable write with O_DSYNC flag, so for a fsync call over NFS mount point, barrier feature always needs to check for writev and its correspoding flags. So to meet all the coditions of write with O_SYNC and fsync getting blocked when barrier is enabled the check has been modified with following: if (!((flags | fd->flags) & (O_SYNC | O_DSYNC))) Point to be noted here is we need to check both fd's flag and the explicit flag as for NFS write fd->flags is 0. | fsync calls on NFS mount were not blocked, when barrier was enabled. This is because NFS handles fsync calls differently. Now with this fix, fsync calls on NFS mount will be blocked, when barrier was enabled. |
| John Skeoch | 2014-08-11 23:23:16 UTC | CC | vshastry | |
| errata-xmlrpc | 2014-09-22 18:04:08 UTC | Status | VERIFIED | RELEASE_PENDING |
| errata-xmlrpc | 2014-09-22 19:39:17 UTC | Status | RELEASE_PENDING | CLOSED |
| Resolution | --- | ERRATA | ||
| Last Closed | 2014-09-22 15:39:17 UTC | |||
| Rejy M Cyriac | 2015-05-13 16:56:50 UTC | Target Release | --- | RHGS 3.0.0 |
| Target Milestone | RHS 3.0.0 | --- | ||
| Rejy M Cyriac | 2016-09-17 14:43:31 UTC | Sub Component | core | |
| CC | rhs-bugs, storage-qa-internal | |||
| Component | glusterfs | core |
Back to bug 1100571