Back to bug 1381511

Who When What Removed Added
Marius Cornea 2016-10-04 12:32:36 UTC CC mcornea
Frank Zdarsky 2016-10-04 14:04:00 UTC Blocks 1355903
Lucas Alvares Gomes 2016-10-04 18:25:32 UTC Link ID OpenStack gerrit 381893
Dmitry Tantsur 2016-11-11 12:14:52 UTC Status NEW ASSIGNED
Target Release --- 10.0 (Newton)
CC apevec, dtantsur, jjoyce, jschluet, lhh
Component openstack-ironic python-ironic-lib
Version 11.0 (Ocata) 10.0 (Newton)
Dmitry Tantsur 2016-11-14 10:58:00 UTC Link ID OpenStack gerrit 396636
Dmitry Tantsur 2016-11-14 15:39:41 UTC Status ASSIGNED POST
Jon Schlueter 2016-11-14 19:26:52 UTC Link ID OpenStack gerrit 381893
Target Milestone --- rc
Jon Schlueter 2016-11-18 02:51:58 UTC Status POST MODIFIED
Fixed In Version python-ironic-lib-2.1.1-2.el7ost
errata-xmlrpc 2016-11-18 11:41:31 UTC Status MODIFIED ON_QA
Sergii Nozhka 2016-11-21 10:12:33 UTC CC snozhka
QA Contact rbartal snozhka
Sergii Nozhka 2016-11-21 12:59:17 UTC Status ON_QA VERIFIED
QA Contact snozhka rbartal
Sergii Nozhka 2016-11-21 12:59:50 UTC QA Contact rbartal snozhka
Lucas Alvares Gomes 2016-11-22 16:39:07 UTC Doc Text Cause:
Ironic did not distinguished between primary and logical partitions when counting the number of partitions present in the MBR of a disk image. When deploying a node with configdrive Ironic will need to create an extra primary partition to copy it onto. If the disk already contains 4 primary partitions the deployment should fail, but, for this bug Ironic was counting logical partitions as they were primaries and failing even if there was space for the configdrive partition.

Consequence:
The deployment would fail even if the image was built correctly (leaving space for one more primary partition).

Fix:
Distinguish primary and logical partitions when counting them.

Result:
Deployment with such image would succeed.
Doc Type If docs needed, set a value Bug Fix
Jon Schlueter 2016-12-01 15:50:07 UTC Keywords Triaged
Dan Macpherson 2016-12-08 03:39:04 UTC CC dmacpher
Doc Text Cause:
Ironic did not distinguished between primary and logical partitions when counting the number of partitions present in the MBR of a disk image. When deploying a node with configdrive Ironic will need to create an extra primary partition to copy it onto. If the disk already contains 4 primary partitions the deployment should fail, but, for this bug Ironic was counting logical partitions as they were primaries and failing even if there was space for the configdrive partition.

Consequence:
The deployment would fail even if the image was built correctly (leaving space for one more primary partition).

Fix:
Distinguish primary and logical partitions when counting them.

Result:
Deployment with such image would succeed.
OpenStack Bare Metal (ironic) provides user data to new nodes through the creation of a configdrive as an extra primary partition. This requires a free primary partition available on the node's disk. However, a bug caused OpenStack Bare Metal to not distinguish between primary and extended partitions, which caused the partition count to report no free partitions available for the configdrive. This fix distinguishes between primary and extended partitions. Deployments now succeed without error.
errata-xmlrpc 2016-12-14 13:47:35 UTC Status VERIFIED RELEASE_PENDING
errata-xmlrpc 2016-12-14 16:07:17 UTC Status RELEASE_PENDING CLOSED
Resolution --- ERRATA
Last Closed 2016-12-14 11:07:17 UTC

Back to bug 1381511