Back to bug 2107404

Who When What Removed Added
Vikhyat Umrao 2022-07-14 22:41:05 UTC Assignee nojha mbreizma
Status NEW ASSIGNED
Red Hat One Jira (issues.redhat.com) 2022-07-14 22:42:02 UTC Link ID Red Hat Issue Tracker RHCEPH-4767
Vikhyat Umrao 2022-07-14 22:42:54 UTC Summary snapshots will not be deleted after upgrade from nautilus to pacific [RHCS 6] Snapshots will not be deleted after upgrade from nautilus to pacific
Vikhyat Umrao 2022-07-14 22:44:24 UTC Blocks 2107405
Neha Ojha 2022-07-14 23:41:37 UTC Summary [RHCS 6] Snapshots will not be deleted after upgrade from nautilus to pacific [RHCS 6] removing snapshots created in nautilus after upgrading to pacific leaves clones around
Veera Raghava Reddy 2022-07-15 16:43:58 UTC CC vereddy
Vikhyat Umrao 2022-07-15 16:46:00 UTC Comment 0 updated
Neha Ojha 2022-07-18 18:25:05 UTC Doc Type If docs needed, set a value Bug Fix
Neha Ojha 2022-08-19 03:57:00 UTC CC mbreizma
Link ID Github ceph/ceph/pull/47133
Flags needinfo?(mbreizma)
Matan Breizman 2022-08-22 11:38:29 UTC Status ASSIGNED POST
Flags needinfo?(mbreizma)
Vikhyat Umrao 2022-08-22 14:38:04 UTC Flags needinfo?(mbreizma)
Neha Ojha 2022-08-22 15:15:35 UTC Flags needinfo?(mbreizma)
errata-xmlrpc 2022-08-22 20:57:54 UTC Status POST MODIFIED
CC tserlin
Fixed In Version ceph-17.2.3-12.el9cp
Status MODIFIED ON_QA
Masauso Lungu 2022-09-09 10:12:46 UTC CC mlungu
Docs Contact mlungu
Flags needinfo?(mbreizma)
Matan Breizman 2022-09-11 06:49:19 UTC Doc Text Cause: Octopus modified the SnapMapper key format from
<LEGACY_MAPPING_PREFIX><snapid>_<shardid>_<hobject_t::to_str()>
to
<MAPPING_PREFIX><pool>_<snapid>_<shardid>_<hobject_t::to_str()>
When this change was introduced, 94ebe0e also introduced a conversion
with a crucial bug which essentially destroyed legacy keys by mapping them
to
<MAPPING_PREFIX><poolid>_<snapid>_
without the object-unique suffix.

Consequence: SnapMapper's keys were wrongly converted resulting in clone objects which were unable to be removed.

Fix: SnapMapper's legacy conversion was fixed to match the new key format.

Result: After fixing the conversion, it is again possible to remove clone objects created in N (or earlier) after upgrading to O (or later).
Matan Breizman 2022-09-18 06:22:26 UTC CC skanta
QA Contact pdhiran skanta
Flags needinfo?(mbreizma) needinfo-
Pawan 2022-09-19 09:12:23 UTC CC pdhiran
Masauso Lungu 2022-09-21 18:25:49 UTC Blocks 2126050
Masauso Lungu 2022-09-27 13:46:06 UTC Doc Text Cause: Octopus modified the SnapMapper key format from
<LEGACY_MAPPING_PREFIX><snapid>_<shardid>_<hobject_t::to_str()>
to
<MAPPING_PREFIX><pool>_<snapid>_<shardid>_<hobject_t::to_str()>
When this change was introduced, 94ebe0e also introduced a conversion
with a crucial bug which essentially destroyed legacy keys by mapping them
to
<MAPPING_PREFIX><poolid>_<snapid>_
without the object-unique suffix.

Consequence: SnapMapper's keys were wrongly converted resulting in clone objects which were unable to be removed.

Fix: SnapMapper's legacy conversion was fixed to match the new key format.

Result: After fixing the conversion, it is again possible to remove clone objects created in N (or earlier) after upgrading to O (or later).
.Users can remove cloned objects after upgrading a cluster

Previously, after upgrading a cluster from {storage-product} 4 to {storage-product} 5 , removing snapshots of objects created in earlier versions would leave clones, which could not be removed. This was because the SnapMapper key’s were wrongly converted.

With this fix, SnapMapper’s legacy conversation was updated to match the new key format and cloned objects in earlier versions of Ceph can now be easily removed after an upgrade.
Flags needinfo?(mbreizma)
Matan Breizman 2022-09-28 06:30:30 UTC Flags needinfo?(mbreizma)
Red Hat Bugzilla 2022-12-31 19:09:54 UTC Status ON_QA VERIFIED
QA Contact skanta pdhiran
CC skanta
Red Hat Bugzilla 2022-12-31 19:13:38 UTC CC amathuri
Red Hat Bugzilla 2022-12-31 19:32:47 UTC QA Contact pdhiran
CC pdhiran
Red Hat Bugzilla 2022-12-31 20:00:12 UTC CC sseshasa
Red Hat Bugzilla 2022-12-31 22:29:23 UTC Assignee mbreizma nojha
CC mbreizma
Red Hat Bugzilla 2022-12-31 22:43:40 UTC CC rfriedma
Red Hat Bugzilla 2022-12-31 23:43:47 UTC CC rzarzyns
Red Hat Bugzilla 2022-12-31 23:46:05 UTC CC akupczyk
Red Hat Bugzilla 2023-01-01 05:35:33 UTC CC ksirivad
Red Hat Bugzilla 2023-01-01 05:40:01 UTC CC tserlin
Red Hat Bugzilla 2023-01-01 06:27:21 UTC CC lflores
Red Hat Bugzilla 2023-01-01 06:29:12 UTC CC choffman
Red Hat Bugzilla 2023-01-01 08:39:05 UTC Assignee nojha nobody
CC nojha
Red Hat Bugzilla 2023-01-01 08:39:59 UTC CC pdhange
Red Hat Bugzilla 2023-01-01 08:46:58 UTC CC vereddy
Red Hat Bugzilla 2023-01-01 08:50:23 UTC CC vumrao
Alasdair Kergon 2023-01-04 04:40:45 UTC CC akupczyk
Alasdair Kergon 2023-01-04 04:43:34 UTC CC amathuri
Alasdair Kergon 2023-01-04 04:46:11 UTC Assignee nobody mbreizma
Alasdair Kergon 2023-01-04 04:55:59 UTC QA Contact skanta
Alasdair Kergon 2023-01-04 05:08:58 UTC CC ksirivad
Alasdair Kergon 2023-01-04 05:10:58 UTC CC lflores
Alasdair Kergon 2023-01-04 05:14:04 UTC CC mbreizma
Alasdair Kergon 2023-01-04 05:21:38 UTC CC nojha
Alasdair Kergon 2023-01-04 05:28:18 UTC CC pdhange
Alasdair Kergon 2023-01-04 05:30:13 UTC CC pdhiran
Alasdair Kergon 2023-01-04 05:34:52 UTC CC rfriedma
Alasdair Kergon 2023-01-04 05:37:37 UTC CC rzarzyns
Alasdair Kergon 2023-01-04 05:41:45 UTC CC skanta
Alasdair Kergon 2023-01-04 05:59:30 UTC CC vumrao
Alasdair Kergon 2023-01-04 06:13:47 UTC CC choffman
Alasdair Kergon 2023-01-04 06:56:31 UTC CC sseshasa
Alasdair Kergon 2023-01-04 06:59:12 UTC CC vereddy
Red Hat Bugzilla 2023-01-09 08:29:33 UTC CC ceph-eng-bugs
Alasdair Kergon 2023-01-09 19:43:36 UTC CC ceph-eng-bugs
errata-xmlrpc 2023-03-20 18:38:03 UTC Status VERIFIED RELEASE_PENDING
errata-xmlrpc 2023-03-20 18:57:08 UTC Resolution --- ERRATA
Status RELEASE_PENDING CLOSED
Last Closed 2023-03-20 18:57:08 UTC
errata-xmlrpc 2023-03-20 18:57:49 UTC Link ID Red Hat Product Errata RHBA-2023:1360

Back to bug 2107404