Back to bug 2222428
| Who | When | What | Removed | Added |
|---|---|---|---|---|
| Red Hat Bugzilla | 2023-07-12 17:42:53 UTC | Pool ID | sst_system_roles_rhel_9 | |
| RHEL Program Management | 2023-07-12 17:43:01 UTC | Keywords | Triaged | |
| Red Hat One Jira (issues.redhat.com) | 2023-07-12 17:45:16 UTC | Link ID | Red Hat Issue Tracker RHELPLAN-162177 | |
| Rich Megginson | 2023-07-12 17:51:55 UTC | Doc Type | If docs needed, set a value | Bug Fix |
| Status | NEW | POST | ||
| Link ID | Github linux-system-roles/firewall/pull/153 | |||
| Target Release | --- | 9.3 | ||
| Rich Megginson | 2023-07-12 17:55:39 UTC | Blocks | 2222433 | |
| Rich Megginson | 2023-07-12 18:38:11 UTC | CC | djez, jharuda, vdanek | |
| Flags | needinfo?(djez) needinfo?(jharuda) needinfo?(vdanek) | |||
| Jakub Haruda | 2023-07-18 17:48:07 UTC | QA Contact | rhel-cs-system-management-subsystem-qe | jharuda |
| Flags | needinfo?(jharuda) | |||
| Rich Megginson | 2023-07-21 17:30:57 UTC | Fixed In Version | rhel-system-roles-1.22.0-0.16.el9 | |
| Status | POST | MODIFIED | ||
| errata-xmlrpc | 2023-07-21 17:32:44 UTC | Status | MODIFIED | ON_QA |
| Jakub Haruda | 2023-07-27 14:54:53 UTC | Status | ON_QA | VERIFIED |
| Rich Megginson | 2023-08-10 13:38:16 UTC | Doc Text | Enhancement: - firewall_lib.py - check if service exists before running firewalld methods that would cause failure - fails if service does not exist and in diff mode, warns if in check mode and service does not exist - README.md - reflects changes and explains interaction with check mode - tests/tests_service.yml - add integration test case for adding non-existent services in check mode - tests/unit/test_firewall_lib.py - Mock necessary output from fw.config().getServiceNames() Reason: Better compliance with Ansible best practices for check mode (not failing in check mode, especially where they would not fail in diff mode) Reason for this particular solution - We cannot track changes from previous check modes without overhauling how check mode is handled throughout the entire system role. Result: Undefined services being enabled or disabled will not result in failure while in check mode, but a warning will be displayed intended to prompt the user to confirm that the service is defined in a previous play, since the same action could result in failure when run in diff mode. Issue Tracker Tickets (Jira or BZ if any): - Addresses GitHub Issue #146 |
Back to bug 2222428