Bug 102882

Summary: Folder.java sets/gets a static 'wasNew' variable in beforeSave/afterSave methods
Product: [Retired] Red Hat Enterprise CMS Reporter: Daniel Berrange <berrange>
Component: otherAssignee: ccm-bugs-list
Status: CLOSED WONTFIX QA Contact: Jon Orris <jorris>
Severity: high Docs Contact:
Priority: medium    
Version: 6.0   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-09-02 17:42:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 108447    

Description Daniel Berrange 2003-08-22 09:54:39 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 Galeon/1.2.9 (X11; Linux i686; U;) Gecko/20030314

Description of problem:
Folder.java is setting & getting a static 'm_wasNew' variable in its
beforeSave/afterSave methods. This should obviously /not/  be a static variable
unless we can guarentee that there are no concurrent saves of Folder objects ;-)


Version-Release number of selected component (if applicable):


How reproducible:
Sometimes

Steps to Reproduce:
1. Get two threads to save a folder at the same time

Actual Results:  One thread does the wrong thing in afterSave.

Expected Results:  Both threads execute afterSave correctly.

Additional info:

Comment 1 Daniel Berrange 2003-08-22 10:00:43 UTC
cf featurezilla 102883

Comment 2 Richard Li 2003-12-23 20:38:39 UTC
This was fixed in the land of the test-search branch (@35351).

Comment 3 Daniel Berrange 2004-01-05 10:02:25 UTC
Opps, a little confusion about releases. When I opened this ticket,
'nightly' was still referring to Troika (6.0). That branch is still
broken:

dan@camden$ grep m_wasNew cms/6.0/src/com/arsdigita/cms/Folder.java 
    private static boolean m_wasNew;
        m_wasNew = isNew();
        if (m_wasNew) {
dan@camden$ 


Comment 4 Richard Li 2004-01-05 14:18:16 UTC
not rc0

Comment 5 Daniel Berrange 2006-09-02 17:42:19 UTC
Closing old tickets