Bug 110792

Summary: bad source code
Product: [Fedora] Fedora Reporter: d.binderman
Component: ipchainsAssignee: Mike A. Harris <mharris>
Status: CLOSED WONTFIX QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: medium    
Version: 1Keywords: EasyFix, Triaged
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-02-17 09:04:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description d.binderman 2003-11-24 16:07:24 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)

Description of problem:


I just tried to compile package ipchains-1_3_10-19 from Fedora.

The compiler said

1.

ipchains.c:2193: warning: `+' flag used with `%x' printf format
ipchains.c:2193: warning: `+' flag used with `%x' printf format

The source code is

                        fprintf(fp, FMT("0x%+-10x ","mark 0x%+x "),
                                (int)fw->ipfw.fw_mark);

The + flag is used for signed quantities, the %x flag is used for
unsigned quantities. You can have one or the other, not both. Pick 
one.


Version-Release number of selected component (if applicable):
ipchains-1_3_10-19 

How reproducible:
Always

Steps to Reproduce:
1. by inspection
2.
3.
    

Additional info:

Comment 1 Mike A. Harris 2003-12-15 13:22:05 UTC
These types of rather IMHO harmless warnings, should be reported
directly to the upstream maintainer of the given software, so that
it gets fixed upstream and not just in one distribution.

Low priority issues like this also get a higher priority when
accompanied by a patch that fixes the issue.  ;o)

Comment 2 Mike A. Harris 2004-02-17 09:04:56 UTC
Fedora Core 2 will have a 2.6.x kernel, and we have dropped ipchains
support in our Fedora Core kernel because it isn't widely used or
tested nowadays.  We no longer support ipchains in future OS releases,
so I'm closing all ipchains bug reports that are open which are not
security related or mission critical.

Closing as 'WONTFIX'