|Summary:||tda1004x module is missing|
|Product:||[Fedora] Fedora||Reporter:||Bernd Bartmann <bernd.bartmann>|
|Component:||kernel||Assignee:||Arjan van de Ven <arjanv>|
|Status:||CLOSED UPSTREAM||QA Contact:|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2004-05-03 19:59:13 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
Description Bernd Bartmann 2004-02-16 17:05:32 UTC
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031114 Description of problem: The module tda1004x (DVB-T demodulator chip) is missing from the FC2 Test 1 kernel. This module is required to get DVB-T running with the Hauppauge WinTV Nova-T card. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. search for tda1004x kernel module 2. 3. Additional info:
Comment 1 Bernd Bartmann 2004-02-16 17:31:43 UTC
The module does not appear in "make menuconfig" when using the FC2 Test1 supplied .config file due to "CONFIG_STANDALONE=y"
Comment 2 Arjan van de Ven 2004-02-16 17:34:12 UTC
"CONFIG_STANDALONE=y" means we don't want build-time firmware. Which is correct, we can't generally download all firmware for some driver and just distribute it; quite often that's not even allowed.
Comment 3 Bernd Bartmann 2004-02-16 17:40:27 UTC
Arjan, the existense of the firmware file is not a build time requirement. In fact you can also supply a different firmware filename at module load time.
Comment 4 Arjan van de Ven 2004-02-16 17:42:51 UTC
then the Kconfig for the file is borken.....
Comment 5 Bernd Bartmann 2004-02-16 17:55:30 UTC
Just sent a mail to the DVB mailing list about this problem.
Comment 6 Bernd Bartmann 2004-02-16 20:38:20 UTC
The DVD guys seem to have fixed this in their CVS after my problem report, but now I have another problem. In the meantime I rebuild the FC2 Test1 kernel to include the tda1004x module (using the supplied .config). While trying to load the tda1004x module I'm getting this error message: FATAL: Error inserting tda1004x (/lib/modules/2.6.1-1.65bb/kernel/drivers/media/dvb/frontends/tda1004x.ko): Unknown symbol in module, or unknown parameter (see dmesg) In /var/log/messages I get: tda1004x: Unknown symbol sys_close Any ideas how to fix this one?
Comment 7 Arjan van de Ven 2004-02-16 20:45:08 UTC
they have very evil code there; it's not allowed to read files from kernel space like that, they should use request_firmware interface
Comment 8 Bernd Bartmann 2004-02-17 23:07:26 UTC
Now it finally works for me. Watching DVB-T television the whole evening :-) All I had to do was to re-add EXPORT_SYMBOL(sys_close) to fs/open.c which was removed by your linux-2.6.0-compile.patch.
Comment 9 Neil Aspinall 2004-02-20 09:35:50 UTC
I also got this working by changing all calls to sys_close() into calls to close() in drivers/media/dvb/frontends/tda1004x.c. Is there a reason for Fedora not exporting sys_close() from fs/open.c?
Comment 10 Arjan van de Ven 2004-02-20 09:38:32 UTC
any user of it is broken. It cannot be used correctly. tda1004x.c is rather broken. Really. Even when not using request_firmware() and co, opening a file needs to be done differently.
Comment 11 Alan Cox 2004-05-03 19:59:13 UTC
Being resolved upstream, will be picked up over time once firmware handling is in the base kernel [and possibly when someone reminds us to turn it on 8)].
Comment 12 Thomas Vander Stichele 2004-08-25 14:56:50 UTC
Is there much value of deprecating/removing stuff from the FC kernel that's not (yet) done upstream ? I thought the new point of FC kernels was to stick as close to upstream as possible ?
Comment 13 Phil Anderson 2005-01-04 12:38:37 UTC
# ChangeSet # 2004/12/13 08:34:11-08:00 email@example.com # [PATCH] dvb: frontend update # # - tda1004x: fixed firmware upload problems <snip> # Signed-off-by: Michael Hunold <firstname.lastname@example.org> # Signed-off-by: Andrew Morton <email@example.com> # Signed-off-by: Linus Torvalds <firstname.lastname@example.org> Looks like a fix for this is finally on the way.....