Bug 116103
Summary: | Multiple missing return statements | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | d.binderman |
Component: | rdist | Assignee: | Phil Knirsch <pknirsch> |
Status: | CLOSED NOTABUG | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 1 | CC: | rvokal |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2004-04-14 12:31:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
d.binderman
2004-02-18 10:27:12 UTC
Bogous error messages from your compiler, in both v1 and v2 sources these functions are declared and defined already as void. Read ya, Phil
>Bogous error messages from your compiler
The compiler usually produces these messages
for K&R style function definitions, like
f( a, b)
int a;
char b;
{
Note missing return type.
I usually find that upgrading the prototypes to ISO C
fixes the problem.
OK, i'll be a more specific: Looking at gram.y for example the function insert is defined like this: void insert(label, files, hosts, subcmds) char *label; struct namelist *files, *hosts; struct subcmd *subcmds; So it is defined as void and the compiler spits out obviously a wrong warning. Same for append() and yyerror() in gram.y, usage() and docmdargs() in rdist.c, define() in lookup.c and setargs_settup() in setargs.c Closing this again as not a bug, the compiler is broken resp. spits out bogous warnings. Read ya, Phil Actually i just remembered that i fixed a few of the really wrong function definitions some time ago in the cleanup patch (which also fixes a miscompilation on ia64). Please test the latest package from the development tree, that compiles without a single warning on my system here now. Read ya, Phil |