Bug 1243506

Summary: Review Request: perl-Net-HL7 - Simple perl API for HL7 messages
Product: [Fedora] Fedora Reporter: Bill Pemberton <wfp5p>
Component: Package ReviewAssignee: Petr Šabata <psabata>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mattdm, package-review, psabata
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: psabata: fedora-review+
gwync: fedora-cvs+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-10-01 16:05:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 182235    

Description Bill Pemberton 2015-07-15 15:42:05 UTC
Spec URL: https://wfp.fedorapeople.org/perl-Net-HL7.spec
SRPM URL: https://wfp.fedorapeople.org/perl-Net-HL7-0.80-1.fc22.src.rpm

Description:
The Net-HL7 package is a simple Perl API for creating, parsing,
sending, and receiving HL7 messages.

Fedora Account System Username: wfp

Comment 1 Petr Šabata 2015-07-16 09:19:40 UTC
This Beerware variant doesn't appear to be free since the drink is mandatory:

                     BEER-WARE LICENSE

                   Version 666, July 2012

You can use this stuff and do whatever you like with it on the
following condition:

0. Would you ever be in a situation where you are able to offer
   us, or one of us, a beer, or if unavailable, an alcoholic 
   beverage of your choice, you must do so.

   Wyldebeast & Wunderliebe


Compare to https://fedoraproject.org/wiki/Licensing/Beerware

Comment 2 Bill Pemberton 2015-07-19 22:10:23 UTC
I was a afraid of that.  I thought ANY of the Beerware weren't allowed, but then I saw the above link and (falsely) thought Beerware was Beerware....

Comment 3 Petr Šabata 2015-07-20 15:28:38 UTC
(In reply to Bill Pemberton from comment #2)
> I was a afraid of that.  I thought ANY of the Beerware weren't allowed, but
> then I saw the above link and (falsely) thought Beerware was Beerware....

You can also ask on the legal@ list.  I'm not sure whether simply blocking FE-Legal is enough to get any legal attention.

You could also contact upstream, explain the situation and ask them change the license to be a little bit more permissive.

Comment 4 Petr Šabata 2015-08-11 17:11:16 UTC
I've mailed the legal list.

Comment 5 Petr Šabata 2015-08-19 12:37:44 UTC
Sadly, confirmed as a non-free license.  Closing the review.

Comment 6 Matthew Miller 2015-08-19 16:11:58 UTC
Might be worth contacting the project authors and asking if they'd be open to switching to a more friendly, less demanding license variant.

Comment 7 Bill Pemberton 2015-08-19 16:15:41 UTC
Yes, I was going to contact the authors.  I've just not gotten to it yet.

Comment 8 Bill Pemberton 2015-09-17 16:43:25 UTC
The author agreed to change the wording of the license from "you must do so" to "you are strongly encouraged to do so".  I think that makes it ok now, so here's another version of the rpm.

Spec URL: https://wfp.fedorapeople.org/perl-Net-HL7.spec
SRPM URL: https://wfp.fedorapeople.org/perl-Net-HL7-0.81-1.fc22.src.rpm

Comment 9 Petr Šabata 2015-09-17 19:09:32 UTC
Wonderful :)

Comment 10 Petr Šabata 2015-09-17 19:35:34 UTC
* The license isn't just Beerware.  Everything under the lib/Net/HL7/ directory is licensed under the usual `same as perl' terms.
  The correct License tag would be `Beerware and (GPL+ or Artistic)'.

* Some build deps are missing:
  - perl(base)
    + lib/Net/HL7/Daemon.pm:4
    + lib/Net/HL7/Daemon.pm:121
    + lib/Net/HL7/Messages/ACK.pm:17
    + lib/Net/HL7/Request.pm:14
    + lib/Net/HL7/Response.pm:14
    + lib/Net/HL7/Segments/MSH.pm:15
  - perl(Config)
    + t/daemon.t:36
    + t/message.t:6
  - perl(Errno)
    + lib/Net/HL7/Connection.pm:7
    + lib/Net/HL7/Daemon.pm:213
  - perl(IO::Socket)
    + lib/Net/HL7/Connection.pm:6
    + lib/Net/HL7/Daemon.pm:3
    + lib/Net/HL7/Daemon.pm:119
  - perl(IO::Socket::INET)
    + lib/Net/HL7/Daemon.pm:4
    + lib/Net/HL7/Daemon.pm:121
  - perl(POSIX)
    + lib/Net/HL7/Segments/MSH.pm:16
  - perl(Sys::Hostname)
    + lib/Net/HL7/Daemon.pm:91

* The Sys::Hostname dependency won't get autodetected by our generators.
  You need to require it explicitly.

* You should own the %{perl_vendorlib}/Net directory here, too.
  %{perl_vendorlib}/* is sufficient.

Comment 11 Bill Pemberton 2015-09-17 20:09:29 UTC
Updated to address the above comments:

Spec URL: https://wfp.fedorapeople.org/perl-Net-HL7.spec
SRPM URL: https://wfp.fedorapeople.org/perl-Net-HL7-0.81-2.fc22.src.rpm

Comment 12 Petr Šabata 2015-09-17 20:13:11 UTC
Ack, all done.  Approving.

Comment 13 Bill Pemberton 2015-09-17 20:29:42 UTC
New Package SCM Request
=======================
Package Name: perl-Net-HL7
Short Description: Simple perl API for HL7 messages
Upstream URL: http://search.cpan.org/dist/Net-HL7/
Owners: wfp
Branches: f23 el6 epel7
InitialCC: perl-sig

Comment 14 Gwyn Ciesla 2015-09-18 00:11:24 UTC
Git done (by process-git-requests).

Comment 15 Fedora Update System 2015-09-18 02:11:45 UTC
perl-Net-HL7-0.81-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16141

Comment 16 Fedora Update System 2015-09-18 13:38:08 UTC
perl-Net-HL7-0.81-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8134

Comment 17 Fedora Update System 2015-09-18 13:45:48 UTC
perl-Net-HL7-0.81-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8135

Comment 18 Fedora Update System 2015-09-19 00:20:50 UTC
perl-Net-HL7-0.81-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-Net-HL7'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16141

Comment 19 Fedora Update System 2015-09-19 03:19:36 UTC
perl-Net-HL7-0.81-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-Net-HL7'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8135

Comment 20 Fedora Update System 2015-09-19 03:21:22 UTC
perl-Net-HL7-0.81-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update perl-Net-HL7'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8134

Comment 21 Upstream Release Monitoring 2015-09-24 15:04:41 UTC
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

Comment 22 Fedora Update System 2015-10-01 16:05:41 UTC
perl-Net-HL7-0.81-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 23 Fedora Update System 2015-10-07 20:10:37 UTC
perl-Net-HL7-0.81-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2015-10-07 22:29:53 UTC
perl-Net-HL7-0.81-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.