Bug 141932

Summary: mount with MS_BIND flag accesses invalid data
Product: [Fedora] Fedora Reporter: Ulrich Drepper <drepper>
Component: straceAssignee: Roland McGrath <roland>
Status: CLOSED ERRATA QA Contact: Brian Brock <bbrock>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ldv
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2005-130 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-02-02 04:36:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
Patch to add some more flags and support for not using printpath none

Description Ulrich Drepper 2004-12-06 08:12:46 UTC
Description of problem:
If the MS_BIND or MS_MOVE or MS_REMOUNT flag is used with mount, the filesystem
parameter is ignored.  The user might pass garbage (or NULL).  The printpath
call currently used to print the value then fails in umovestr.  This should be
avoided.

Version-Release number of selected component (if applicable):
strace-4.5.8-1

How reproducible:
always

Steps to Reproduce:
1.run code using umount with MS_BIND
2.
3.
  
Actual results:
mount("/home/drepper/tmp", "/tmp", umovestr: Input/output error
0, 0x1000, 0) = 0


Expected results:
mount("/home/drepper/tmp", "/tmp", 0, MS_BIND, 0) = 0


Additional info:
The attached patch should do the trick.

Comment 1 Ulrich Drepper 2004-12-06 08:12:46 UTC
Created attachment 107935 [details]
Patch to add some more flags and support for not using printpath

Comment 2 Dmitry V. Levin 2004-12-20 01:47:25 UTC
There are few more MS_* flags in the current kernel which could be
added altogether.

Comment 3 Roland McGrath 2005-02-02 04:36:37 UTC
I've put the fixes in, though the patch was not complete as is.

Comment 4 Tim Powers 2005-05-19 21:10:02 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2005-131.html