Bug 1608973

Summary: Possible Patented items in gnuradio
Product: [Fedora] Fedora Reporter: Dave Olsthoorn <dave.olsthoorn>
Component: gnuradioAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jskarvad, lucilanga, mmahut, tcallawa
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gnuradio-3.7.13.4-3.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-08-10 20:35:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 182235    
Attachments:
Description Flags
cleaning script none

Description Dave Olsthoorn 2018-07-26 15:31:25 UTC
Description of problem:
The source of gnuradio contains both decoders and encoders for dvb-t, dvb-t2 (for data streams, not for codecs) and maybe more. These components are possibly patented and thus not allowed in fedora.

Version-Release number of selected component (if applicable):
gnuradio-3.7.13.3-3.fc28

Comment 1 Dave Olsthoorn 2018-07-26 15:44:49 UTC
List of patents applying to DVB-T: http://www.sisvel.com/DVB-T/Patents.pdf
List of patents applying to DVB-T2: http://www.sisvel.com/DVB-T2/Patents.pdf

Comment 3 Tom "spot" Callaway 2018-07-27 18:44:35 UTC
Okay. DVB-T2 and ATSC support needs to come entirely out of the Fedora package. Everything seems to have expired for DVB-T, so it could stay, but I'm not sure if keeping the gr-dtv module in Fedora without ATSC and DVB-T2 is the right decision. It seems like removing gr-atsc and gr-drv and then making rpmfusion packages for them would provide a better user experience.

Jaroslav, I'll let you decide exactly how you want to do this, but the source tarball needs to be "clean", which means that the gr-atsc/ directory and the gr-dtv/lib/[atsc|dvbt2] directories need to be removed entirely.

Note: I did a local test build removing gr-atsc/ and the gr-dtv/lib/[atsc|dvbt2] directories, and it succeeded, but I don't know if it actually works or not.

Comment 4 Dave Olsthoorn 2018-07-28 16:28 UTC
Created attachment 1471262 [details]
cleaning script

An shell script to clean the tarball of patented content

Comment 5 Tom "spot" Callaway 2018-08-09 14:37:40 UTC
Jaroslav? If you don't take care of this soon, I will do it for you.

Comment 6 Jaroslav Škarvada 2018-08-09 14:39:11 UTC
(In reply to Tom "spot" Callaway from comment #5)
> Jaroslav? If you don't take care of this soon, I will do it for you.

Sorry for delay, I will try to resolve it today.

Comment 7 Jaroslav Škarvada 2018-08-09 19:28:42 UTC
(In reply to Tom "spot" Callaway from comment #3)
> Okay. DVB-T2 and ATSC support needs to come entirely out of the Fedora
> package. Everything seems to have expired for DVB-T, so it could stay, but
> I'm not sure if keeping the gr-dtv module in Fedora without ATSC and DVB-T2
> is the right decision. It seems like removing gr-atsc and gr-drv and then
> making rpmfusion packages for them would provide a better user experience.
> 
> Jaroslav, I'll let you decide exactly how you want to do this, but the
> source tarball needs to be "clean", which means that the gr-atsc/ directory
> and the gr-dtv/lib/[atsc|dvbt2] directories need to be removed entirely.
> 
> Note: I did a local test build removing gr-atsc/ and the
> gr-dtv/lib/[atsc|dvbt2] directories, and it succeeded, but I don't know if
> it actually works or not.

Is it needed to repack the tarball, or is it enough to drop the patented content in the %prep phase?

Comment 8 Tom "spot" Callaway 2018-08-10 13:31:47 UTC
You need to repack the tarball.

Comment 9 Jaroslav Škarvada 2018-08-10 14:54:05 UTC
Thanks for info, building the test build now.

Comment 10 Jaroslav Škarvada 2018-08-10 14:54:25 UTC
(In reply to Dave Olsthoorn from comment #4)
> Created attachment 1471262 [details]
> cleaning script
> 
> An shell script to clean the tarball of patented content

Thanks for the script :)

Comment 11 Jaroslav Škarvada 2018-08-10 14:59:32 UTC
I opened upstream bug:
https://github.com/gnuradio/gnuradio/issues/1948

Comment 12 Jaroslav Škarvada 2018-08-10 23:34:06 UTC
It's in the dist-git, but not build. I cannot build it on s390x due to bug 1614512.