Bug 166184

Summary: Review Request: perl-Class-DBI : Simple Database Abstraction
Product: [Fedora] Fedora Reporter: Tom "spot" Callaway <tcallawa>
Component: Package ReviewAssignee: Paul Howarth <paul>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, philipp
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Class-DBI/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-07 19:04:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 166197, 166198, 166201, 166567    
Bug Blocks: 163779, 166185, 166186, 166187, 166188, 166190, 166191, 166192, 166193, 166195, 166196    
Attachments:
Description Flags
Patch addressing review issues none

Description Tom "spot" Callaway 2005-08-17 20:18:24 UTC
Spec Name or Url: 
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI.spec

SRPM Name or Url: 
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-0.96-2.src.rpm

Description: 

Simple Database Abstraction

(NOTE: This package is one of the Maypole dependencies)

Comment 1 Paul Howarth 2005-08-24 12:27:17 UTC
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file legible and written in English
- sources match upstream
- builds OK in mock on FC-4 (i386)
- BR's mostly OK
- no locales, subpackages, libraries, pkgconfigs etc. to worry about
- not relocatable
- directory ownership OK
- no duplicate files or permission issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- redundant BR: perl
- license text not included in package; suggest adding to %prep:
  perldoc -t perlgpl > COPYING
  perldoc -t perlartistic > Artistic
  and to %files:
  %doc COPYING Artistic

Nitpick:

- include BR: perl(Date::Simple) for more test coverage

Note:

- Including a BR: perl(Time::Piece::MySQL) would also improve coverage but this
  is not yet available in Extras or submitted for review, but it's worth adding
  at some point if someone submits that package



Comment 2 Paul Howarth 2005-08-24 12:29:34 UTC
Created attachment 118052 [details]
Patch addressing review issues

Attached patch addresses Needswork and Nitpick issues raised in review

Comment 4 Paul Howarth 2005-08-24 18:04:16 UTC
Approved.

It would be convenient if you could get builds of this package and its
dependencies done, to facilitate reviews (particularly mock builds) of the
packages that depend on it. I've been making a local repo containing the
unreleased packages thus far. Perhaps you have, and they're waiting on the PPC
builder... I dunno.


Comment 5 Paul Howarth 2005-08-24 20:44:54 UTC
Chris Grau has now submitted perl(Time::Piece::MySQL) to Extras (bugzilla
#166700) so you might want to add this as a BR now for extra test coverage.

Comment 6 Paul Howarth 2005-08-26 09:49:52 UTC
Some manual deps need to be added:

Requires: perl(Class::Accessor), perl(Ima::DBI)

These aren't picked up by RPM automatically.


Comment 7 Philip Prindeville 2013-02-27 21:33:11 UTC
*** Bug 916327 has been marked as a duplicate of this bug. ***