Bug 166184
| Summary: | Review Request: perl-Class-DBI : Simple Database Abstraction | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> | ||||
| Component: | Package Review | Assignee: | Paul Howarth <paul> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, philipp | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://search.cpan.org/dist/Class-DBI/ | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2005-09-07 19:04:37 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 166197, 166198, 166201, 166567 | ||||||
| Bug Blocks: | 163779, 166185, 166186, 166187, 166188, 166190, 166191, 166192, 166193, 166195, 166196 | ||||||
| Attachments: |
|
||||||
|
Description
Tom "spot" Callaway
2005-08-17 20:18:24 UTC
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file legible and written in English - sources match upstream - builds OK in mock on FC-4 (i386) - BR's mostly OK - no locales, subpackages, libraries, pkgconfigs etc. to worry about - not relocatable - directory ownership OK - no duplicate files or permission issues - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - redundant BR: perl - license text not included in package; suggest adding to %prep: perldoc -t perlgpl > COPYING perldoc -t perlartistic > Artistic and to %files: %doc COPYING Artistic Nitpick: - include BR: perl(Date::Simple) for more test coverage Note: - Including a BR: perl(Time::Piece::MySQL) would also improve coverage but this is not yet available in Extras or submitted for review, but it's worth adding at some point if someone submits that package Created attachment 118052 [details]
Patch addressing review issues
Attached patch addresses Needswork and Nitpick issues raised in review
-3 fixes it all, (thanks for the patch) New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-0.96-3.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI.spec Approved. It would be convenient if you could get builds of this package and its dependencies done, to facilitate reviews (particularly mock builds) of the packages that depend on it. I've been making a local repo containing the unreleased packages thus far. Perhaps you have, and they're waiting on the PPC builder... I dunno. Chris Grau has now submitted perl(Time::Piece::MySQL) to Extras (bugzilla #166700) so you might want to add this as a BR now for extra test coverage. Some manual deps need to be added: Requires: perl(Class::Accessor), perl(Ima::DBI) These aren't picked up by RPM automatically. *** Bug 916327 has been marked as a duplicate of this bug. *** |