Bug 216544
| Summary: | Review Request: libdvdread - Simple foundation for reading DVD video disks | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
| Component: | Package Review | Assignee: | Michał Bentkowski <mr.ecik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | panemade, rdieter |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-11-27 22:46:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Dominik 'Rathann' Mierzejewski
2006-11-21 00:06:56 UTC
So which package currently needs this package? how can i test its working? how can i read video DVDs? > Note: it does not support encrypted DVDs (i.e. doesn't contain libdvdcss).
So it's completely useless.
(In reply to comment #2) > > Note: it does not support encrypted DVDs (i.e. doesn't contain libdvdcss). > > So it's completely useless. Not quite. You can install libdvdcss from another repository and it'll work with encrypted DVDs, too. (In reply to comment #2) > So it's completely useless. There is afaik software out there that can use libdvdread as provided here. Maybe that software itself is not suitable for Extras -- but even if that's really the case it's IMHO still a good idea to provide libdvdread in Extras. I can review this package but i need to know how can i test its working. (In reply to comment #1) > So which package currently needs this package? how can i test its working? how > can i read video DVDs? gstreamer-plugins(-ugly?) can be built with libdvdread support. Also, there are examples from Debian: lsdvd, dvdbackup. (In reply to comment #3) > (In reply to comment #2) > > > Note: it does not support encrypted DVDs (i.e. doesn't contain libdvdcss). > > > > So it's completely useless. > > Not quite. You can install libdvdcss from another repository and it'll work with > encrypted DVDs, too. Oops. Sorry. In this case it really valuable. ) I reviewed the code and saw that it loads libdvdcss.so.2 in our case. MUST items: * rpmlint output: W: libdvdread-devel no-documentation * package is named well * spec file name is good * package meets Packaging Guideline * package is licensed with an GPL open-source compatible license * License field in spec file matches actual license * license file is included in %doc * md5sums are matching (078788c9241ae16763529e1235502337) * package successfully compiles on x86_64 * no locales * proper %post and %postun sections * not relocatable * package owns directories well * no duplicates in %files * every %files section includes %defattr * proper %clean section * macros used well * -devel subpackage created and looks good Package can be approved :) To resolve any doubts: https://www.redhat.com/archives/fedora-maintainers/2006-November/msg00256.html Imported and built for devel, FC-5 and FC-6 branches requested. Thanks for the review. Package Change Request ====================== Package Name: libdvdread New Branches: EL-5 Updated EPEL Owners: rathann, rdieter Mailed Dominik, he's ok with comaintaining an EPEL branch. cvs done. |