Bug 228471
Summary: | Review Request: hunspell-ee - Estonian hunspell dictionaries | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
Component: | Package Review | Assignee: | manuel wolfshant <manuel.wolfshant> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | manuel.wolfshant |
Target Milestone: | --- | Flags: | manuel.wolfshant:
fedora-review+
notting: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-14 10:26:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Caolan McNamara
2007-02-13 09:39:21 UTC
- package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum 4289cdd695eba079aceed471954f0adfc8059ffa et_EE.aff 712f4651ae2a82bea216cad78b144d182ad1c06f et_EE.dic - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only 2 text files) - the license LGPL stated in the tag is the same as upstream's web site (http://www.meso.ee/~jjpp/speller/,Litsents ) says; the actual license is not included in the final rpm because upstream does not supply an actual "release" but just the two dictionary files - there are only 2 files (word lists) so no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint output is silent on src.rpm; binary gives the following warning: W: hunspell-ee no-documentation which is consistent with the fact that there is nothing in the rpm but the two dictionary files - code, not content - no need for .desktop file APPROVED Obs: please bug upstream to include the LGPL license in case they release the dictionary as a single file (tar/zip/whatever); it would also be a good idea if their dict files would be available at http://ftp.services.openoffice.org/pub/OpenOffice.org/contrib/dictionaries/ 27546 (hunspell-ee): Build on target fedora-development-extras succeeded. |