Bug 23475

Summary: fix to 1.6 to make -I,-X consistent with local filenames (%escapes)
Product: [Retired] Red Hat Linux Reporter: j. alan eldridge <alane>
Component: wgetAssignee: Bill Nottingham <notting>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0CC: rvokal
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-01-06 06:56:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
patch to unescape %xx in paths before fnmatch compares them none

Description j. alan eldridge 2001-01-06 06:54:34 UTC
this patch may backport to 1.5.3 ok.

the -I and -X options give lists of directories to include/exclude from a
recursive suck. there's an inconsistency in the way they are handled in
case the path has funky characters.

e.g., the dir /wow/neat%20stuff will be created with a literal %20 in the
name (not a space).  however, in the -I or -X list, to include or exclude
that dir, you would have to say: /wow/net\ stuff (with an escaped space, or
quoted, or whatever gets it through the shell for you) in order for that
directory to be recognized. this is, well, kinda stupid.

attachment follows which patches the fnmatch function to unescape both
strings before comparing, thus giving consistent behavior. since fnmatch is
used pervasively, this probably fixes a number of other inconsistencies as
well.

patch sent to wget maintainers as well.

Comment 1 j. alan eldridge 2001-01-06 06:56:40 UTC
Created attachment 7125 [details]
patch to unescape %xx in paths before fnmatch compares them

Comment 2 Bill Nottingham 2001-01-06 22:13:05 UTC
Will be fixed in 1.6-1, which will be in the next rawhide release.
Thanks for the patch!