Bug 236537

Summary:	Review Request: gpsbabel - A tool to convert between various formats used by GPS devices
Product:	[Fedora] Fedora	Reporter:	Roozbeh Pournader <roozbeh>
Component:	Package Review	Assignee:	Roozbeh Pournader <roozbeh>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	sander
Target Milestone:	---	Flags:	sander: fedora-review+ wtogami: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-04-19 17:59:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Roozbeh Pournader 2007-04-16 09:13:47 UTC

Spec URL: http://guava.farsiweb.info/~roozbeh/gpsbabel.spec
SRPM URL: http://guava.farsiweb.info/~roozbeh/gpsbabel-1.3.3-1.src.rpm

Description: 
Converts GPS waypoint, route, and track data from one format type
to another.

Comment 1 Sander Hoentjen 2007-04-16 12:12:03 UTC

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license ( GPL ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Suggestion:
You can include gpsbabel-sample.ini in the %doc section, to provide an example
for people to use, but this is up to you.

APPROVED

Comment 2 Roozbeh Pournader 2007-04-16 13:05:59 UTC

New Package CVS Request
=======================
Package Name: gpsbabel
Short Description: A tool to convert between various formats used by GPS devices
Owners: roozbeh
Branches: FC-5 FC-6 EL-5
InitialCC:

Comment 3 Roozbeh Pournader 2007-04-19 17:59:50 UTC

Built in devel, FC-5, FC-6, and EL-5.