Bug 240844

Summary:	/etc/httpd/conf/magic is too simple (PNG is missing)
Product:	Red Hat Enterprise Linux 5	Reporter:	Milan Kerslager <milan.kerslager>
Component:	httpd	Assignee:	Joe Orton <jorton>
Status:	CLOSED ERRATA	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.0	CC:	ohudlick
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-09-02 11:49:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Milan Kerslager 2007-05-22 10:39:04 UTC

The /etc/httpd/conf/magic file is too short and too simple. This seems to be
better to use (longer and better) file /usr/share/file/magic.mime (from "file"
package).

Also PHP is using Apache's magic file and this causes problems when using
MediaWiki and other appliactions, see:
http://meta.wikimedia.org/wiki/Talk:Documentation:Security#Problems_with_PNG_Upload

Comment 1 Milan Kerslager 2007-05-22 10:54:26 UTC

PHP bug filled as bug #240845.

Please consider to use external MIME definition (by requiring "file" package and
by creating symlink from /etc/httpd/conf/magic to /usr/share/file/magic.mime) or
simply copy actual MIME file from package file to the Apache package (does not
sound good as this preserves MIME definition duplication).

Comment 2 RHEL Program Management 2007-12-03 20:42:56 UTC

This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release.  This request will
be reviewed for a future Red Hat Enterprise Linux release.

Comment 3 RHEL Program Management 2008-06-02 20:37:04 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 6 Joe Orton 2008-09-18 15:50:47 UTC

Having reviewed the mod_mime_magic code I'm no longer confident about making this change by default.  The httpd.conf already offers the alternative MIMEMagicFile as a commented-out example.  I'll change this in Fedora Raw Hide to get some wider testing of the use of the magic.mime from file(1).

Comment 8 Joe Orton 2009-06-22 09:39:28 UTC

On testing of this change, when configured to use /usr/share/file/magic.mime, mod_mime_magic will not even detect an HTML file correctly.

mod_mime_magic's magic-file parser is not grokking the newer-format mime files correctly.  I've modified the shipped conf/magic file to support image/png - even this had to use a simplified version of the PNG detection magic.

A better long-term goal might be to use libmagic directly from mod_mime_magic, though I haven't looked into that.

Comment 12 errata-xmlrpc 2009-09-02 11:49:58 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1380.html