Bug 242543
Summary: | Review Request: AcetoneISO - CD/DVD Image Manipulator | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
Component: | Package Review | Assignee: | Dan Horák <dan> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | dan:
fedora-review+
tcallawa: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-11-19 22:16:12 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 242544 | ||
Bug Blocks: |
Description
Tom "spot" Callaway
2007-06-04 18:59:57 UTC
You can expect full review tomorrow, I think. As it distributes original sources without the non-redistributable poweriso binary, it should be mentioned somewhere for the end-user - eg. in %description or in a standalone README.Fedora. The text could be: poweriso utility from original source archive is not included as it is binary-only and not redistributable. Conversion from XY to AB will not be possible. First sorry for this delay, but the review is here: OK source files doesn't match upstream, because non-distributable/non-free file (poweriso) is removed, but the rest was checked to be the same OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPL) and license text is included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Development/i386) and native FC6/x86_64 OK debuginfo package looks complete. OK rpmlint output can be ignored OK final provides and requires look sane: OK no shared libraries are added to the regular linker search paths. BAD doesn't own the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app and the desktop file is properly installed BAD doesn't own the directories it creates. AcetoneISO.kmdr is placed into %{_datadir}/apps/%{name}/scripts, but the directory %{_datadir}/apps/%{name} is unowned Sorry for the delay. New SRPM: http://auroralinux.org/people/spot/review/AcetoneISO-6.7-2.fc8.src.rpm New SPEC: http://auroralinux.org/people/spot/review/AcetoneISO.spec Fixes the directory ownership, desktop file problems, missing dependencies. all issues are fixed, so this package is APPROVED Also AcetoneISO2 changed its license from Creative Commons to GPL3, so it may worth looking at it. (In reply to comment #6) > Also AcetoneISO2 changed its license from Creative Commons to GPL3, so it may > worth looking at it. Yes, but unfortunately, they're also now linking to qt4 (which they can't legally do, because qt4 is GPLv2 only). CVS done and builds building. Thanks for the review. If the qt licensing ever resolves itself, I'll put up AcetoneISO2 for review (package is done, just legally impossible). |