Bug 33081
Summary: | Gimp crashes (font related) | ||||||
---|---|---|---|---|---|---|---|
Product: | [Retired] Red Hat Raw Hide | Reporter: | Itai Nahshon <itai.nahshon> | ||||
Component: | gtk+ | Assignee: | David Mason <dcm> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 1.0 | CC: | msw, otaylor, teg, twaugh | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | i386 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2001-03-30 19:58:11 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Itai Nahshon
2001-03-24 11:56:41 UTC
*** Bug 32106 has been marked as a duplicate of this bug. *** This is a 2-byte font.. could gtk+ have problems with this? Owen? It does work with other 2 byte fonts, though - and the stack of gimp is about 52 k entries deep when it crashes. Once I get information from Matt about his bug, will make a package with the following: Index: gtkfontsel.c =================================================================== RCS file: /cvs/gnome/gtk+/gtk/gtkfontsel.c,v retrieving revision 1.23.2.8 diff -u -r1.23.2.8 gtkfontsel.c --- gtkfontsel.c 2001/02/22 22:02:24 1.23.2.8 +++ gtkfontsel.c 2001/03/28 21:07:09 @@ -1647,7 +1647,7 @@ gpointer data) { GtkFontSelection *fontsel; - gint new_size; + gdouble new_size; gchar *text; gchar buffer[16]; gint i; @@ -1673,11 +1673,11 @@ gtk_entry_set_text(GTK_ENTRY(fontsel->size_entry), buffer); /* Check if the font size has changed, and return if it hasn't. */ - new_size = atoi(text); + new_size = atof(text); if (fontsel->metric == GTK_FONT_METRIC_POINTS) new_size *= 10; - if (fontsel->size == new_size) + if (fontsel->size == (gint)new_size) return; /* If the size was selected by the user we set the selected_size. */ Gimp does not work correctly with other 2 byte fonts but it does not crash. One thing special about the font "newspaper": It does not contain characters in the 7-bit ASCII range. I think we expect that fonts that are calle "iso-10646-1" are expected to contain at least a minimal subset. This is a gtk+ bug. Created attachment 14263 [details]
Here's the fix
Well, thanks for the patch, but look up a few lines.... Oh yeah. I must read mail from bugzilla I must read mail from bugzilla I must read mail from bugzilla After applying the patch, gimp no longer crashes when using the font... but the text in this font is _tiny_. gtk+-1.2.9-5 |