Bug 399941

Summary: Review Request: amanith - Crossplatform framework for 2d/3d vector graphics
Product: [Fedora] Fedora Reporter: Tom "spot" Callaway <tcallawa>
Component: Package ReviewAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: mtasaka: fedora-review+
tcallawa: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-12-20 20:20:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 399951    

Description Tom "spot" Callaway 2007-11-26 19:10:48 UTC
Spec URL: http://www.auroralinux.org/people/spot/review/new/amanith.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/amanith-0.3-2.fc9.src.rpm
Amanith is an OpenSource C++ CrossPlatform framework designed for 2d & 3d
vector graphics.  All the framework is heavily based on a light plug-in

Comment 1 Parag AN(पराग) 2007-11-27 03:49:14 UTC
build gave me
/var/tmp/rpm-tmp.8244: line 29: qmake: command not found

Comment 2 Tom "spot" Callaway 2007-11-27 22:34:57 UTC
How did you manage that? It has qt-devel as a BuildRequires... qmake is part of

Comment 3 Parag AN(पराग) 2007-11-28 03:35:11 UTC
sorry. yes its working fine. I just did koji build

Comment 4 Mamoru TASAKA 2007-12-12 15:06:15 UTC
For 0.3-2

* Dependency for -devel package
  - Please check the dependency (Requires) for -devel subpackage.
    For example, %_includedir/%name/gopenglext.h contains:
    32  #include <GL/glew.h>
    33  // this inclusion to make glew linking working with some platforms (ex: Mac)
    34  #include "amanith/gelement.h"
    35  #ifdef G_OS_WIN
    36          #include <GL/wglew.h>
    37  #endif
    This means amanith-devel should have "Requires: glew-devel".

* SourceURL
  - I recommend to use %{version} tag so that you probably don't have to
    change SourceURL when the new version is released.

! Some misc
export AMANITHDIR=${RPM_BUILD_DIR}/%{name}
  - I like: export AMANITHDIR=$(pwd) (not a blocker)

* Documents
  - Usually the file "INSTALL" is needed for people who want to build
    and install the package by themselves and is not needed for people
    who install the package using rpm.

Comment 5 Mamoru TASAKA 2007-12-19 10:50:37 UTC

Comment 6 Tom "spot" Callaway 2007-12-19 15:29:30 UTC
New Spec URL: http://www.auroralinux.org/people/spot/review/new/amanith.spec

Sorry for the delay, always a million things to do. :)

I didn't change the SourceURL, because I couldn't use the 0.3 version without
parsing the period out somehow. Suggestions on a clean way to do that without
introducing additional macros are welcomed.

Comment 7 Mamoru TASAKA 2007-12-19 16:01:00 UTC
I just tried to rebuild on koji, dist-f9 but it failed.

Comment 9 Mamoru TASAKA 2007-12-19 16:51:07 UTC
Okay. (It is due to mock side change that now "source"ing 
       %_sysconfdir/profile.d/qt.sh is needed? By the way, please
       use %_sysconfdir)

    This package (amanith) is APPROVED by me

Comment 10 Tom "spot" Callaway 2007-12-20 19:28:10 UTC
New Package CVS Request
Package Name: amanith
Short Description: Crossplatform framework for 2d/3d vector graphics
Owners: spot
Branches: F-7 F-8 EL-4 EL-5 
Cvsextras Commits: yes

Comment 11 Tom "spot" Callaway 2007-12-20 19:32:50 UTC
cvs done.

Comment 12 Tom "spot" Callaway 2007-12-20 20:20:21 UTC
Built in F-7, F-8, rawhide.

Can't build in EPEL due to missing glew.

Thanks for the review.