Bug 443655
| Summary: | Clean up handling of short readdir packets in NFS client | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | Jeff Layton <jlayton> | ||||||||
| Component: | kernel | Assignee: | Jeff Layton <jlayton> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Martin Jenner <mjenner> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 4.8 | CC: | davem, dzickus, mgahagan, nhorman, riek, rlerch, staubach, steved, tgraf | ||||||||
| Target Milestone: | rc | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| URL: | http://rhts.lab.boston.redhat.com/cgi-bin/rhts/test_log.cgi?id=1539980 | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: |
Previously, the NFS (Network File System) client was not handling malformed replies from the readdir() function. Consequently, the reply from the server would indicate that the call to the readdir() function was successful, but the reply would contain no entries. With this update, the readdir() reply parsing logic has been changed, such that when a malformed reply is received, the client returns an EIO error.
|
Story Points: | --- | ||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2009-05-18 19:19:22 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 428720 | ||||||||||
| Bug Blocks: | 458752, 461297 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 303355 [details]
clean up short packet handling for NFSv3 readdir
Created attachment 303356 [details]
clean up short packet handling for NFSv4 readdir
This is a backport of the patchset sent upstream and currently in Bruce Fields' git tree. The upstream set should be on track for 2.6.26. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Updating PM score. Committed in 78.11.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/ Release note added. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Cause: the NFS client didn't handle malformed READDIR replies properly. Consequence: If a READDIR reply was truncated at the proper spot (usually due to a buggy server), then it would return success to the caller but no entries. Fix: A patch was submitted upstream to refactor the READDIR reply parsing logic and backported to RHEL4 Result: When one of these malformed replies is received, the client now returns an EIO error to the caller Release note updated. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1,7 +1 @@ -Cause: the NFS client didn't handle malformed READDIR replies properly. +Previously, the NFS (Network File System) client was not handling malformed replies from the readdir() function. Consequently, the reply from the server would indicate that the call to the readdir() function was successful, but the reply would contain no entries. With this update, the readdir() reply parsing logic has been changed, such that when a malformed reply is received, the client returns an EIO error.- -Consequence: If a READDIR reply was truncated at the proper spot (usually due to a buggy server), then it would return success to the caller but no entries. - -Fix: A patch was submitted upstream to refactor the READDIR reply parsing logic and backported to RHEL4 - -Result: When one of these malformed replies is received, the client now returns an EIO error to the caller An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-1024.html |
Created attachment 303354 [details] clean up short packet handling for NFSv2 readdir