Bug 499985

Summary: grub doesn't draw the splash image when the timeout is non-zero
Product: [Fedora] Fedora Reporter: Nicholas Miell <nmiell>
Component: grubAssignee: Peter Jones <pjones>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: fedora, kyleki, pjones, samuel-rhbugs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-05-31 10:14:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
broken behavior
none
correct behavior
none
drop in replacement for the existing grub-keystatus.patch none

Description Nicholas Miell 2009-05-09 20:29:59 UTC
Created attachment 343232 [details]
broken behavior

Description of problem:

The grub keystatus patch in rawhide/F11 broke the background drawing in the non-zero timeout case, leading to ugliness.

Version-Release number of selected component (if applicable):
grub-0.97-50.fc11.src.rpm

How reproducible:
Always

Steps to Reproduce:
1. Set a non-zero boot timeout
  
Actual results:
see attachment

Expected results:
see the other attachment

Comment 1 Nicholas Miell 2009-05-09 20:30:21 UTC
Created attachment 343233 [details]
correct behavior

Comment 2 Nicholas Miell 2009-05-09 20:33:09 UTC
Created attachment 343234 [details]
drop in replacement for the existing grub-keystatus.patch

This drop-in replacement for the existing grub-keystatus.patch file fixes the problem.

Comment 3 Nicholas Miell 2009-05-09 20:34:12 UTC
The interdiff between grub-keystatus.patch and grub-keystatus-fixed.patch is:

diff -u b/stage2/stage2.c b/stage2/stage2.c
--- b/stage2/stage2.c
+++ b/stage2/stage2.c
@@ -235,7 +235,7 @@
   char *cur_entry = 0;
   struct term_entry *prev_term = NULL;
 
-  if (grub_verbose || grub_timeout != 0)
+  if (grub_verbose)
     cls();
 
   /*

Comment 4 Kyle 2009-05-22 15:38:27 UTC
This appears to be a duplicate of Bug 473319.

Comment 5 Eelko Berkenpies 2009-05-31 10:14:50 UTC

*** This bug has been marked as a duplicate of bug 473319 ***