Bug 508033

Summary: new default.el in emacs-22.3-12.fc11 sources breaks spell checking
Product: [Fedora] Fedora Reporter: Daniel <daniel>
Component: emacsAssignee: Daniel Novotny <dnovotny>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 11CC: bugzilla, daniel.distler, debarshir, dnovotny, gustavo, jonathan.underwood
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 22.3-14.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 791179 (view as bug list) Environment:
Last Closed: 2009-07-23 19:02:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
broken spell checking also in emacs-23.0.95 none

Description Daniel 2009-06-25 09:07:20 UTC 
Description of problem: emacs-22.3-12.fc11 comes with five new (compared to latest F10 package emacs-22.3-4.fc10) files:

default.el
emacsclient.patch
emacs.spec
rpm-spec-mode.el
rpm-spec-mode-utc.patch

Files emacsclient.patch and rpm-spec-mode-utc.patch are completely new and the other three have changed context.

New default.el has 2 new lines:
; bz#443549
(setq ispell-program-name "hunspell")

Unfortunately the new default.el breaks spell checking. 

When opening a file with German Umlauts try to change the dictionary under Tools --> Spell Checking --> Change Dictionary. At first sign you'll see much less dictionaries as when compiled with unbroken default.el. Now chose one of the German dictionaries (deutsch, german, deutsch8) and try to check spelling.

Or spell checking hangs completely and one cannot even close the emacs window or one sees an error message like "Can't open affix to dictionary files" or "Ispell process is not running".

When emacs-22.3-12.fc11 is compiled without the added lines in default.el everything runs fine

Version-Release number of selected component (if applicable):
emacs-22.3-12.fc11


Steps to Reproduce:
1. Open German text file with emacs 
2. try to check spelling
3. recompile emacs-22.3-12.fc11 with the following default.el

[root@bl4ckh0l3 4]# more default.el
;;; default.el - loaded after ".emacs" on startup
;;;
;;; Setting `inhibit-default-init' non-nil in "~/.emacs"
;;; prevents loading of this file.  Also the "-q" option to emacs
;;; prevents both "~/.emacs" and this file from being loaded at startup.

newly compiled emacs packages don't have broken spell checking.
Comment 1 Daniel 2009-06-30 22:34:28 UTC 
Created attachment 350029 [details]
broken spell checking also in emacs-23.0.95

ping -c 1 Assigned+CC   ;-)

The above said is true also for emacs-23.0.95 (from latest testing). The two lines:

; bz#443549
(setq ispell-program-name "hunspell")

in default.el break (at least) german spell checking. Compiled emacs-23.0.95 with the attached emacs23.spec
Comment 2 Daniel Novotny 2009-07-02 11:46:06 UTC 
hello,
I fixed this in rawhide. 

In F11 I was waiting for my previous update to hit testing and get tested.

The solution is this: I removed those lines from default.el and took another approach (adding dependency to aspell) to fix Bug 443549 .

I will push the updated package into F11 now.
Comment 3 Fedora Update System 2009-07-02 12:17:51 UTC 
emacs-22.3-14.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/emacs-22.3-14.fc11
Comment 4 Fedora Update System 2009-07-03 19:43:53 UTC 
emacs-22.3-14.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7354
Comment 5 Daniel 2009-07-03 20:01:16 UTC 
Unfortunately nothing has changed yet.
Comment 6 Alex Bennee 2009-07-04 09:53:43 UTC 
It took a while to spread to the mirrors but I can confirm for me at least for me my emacs spell checking is working again. My .emacs happily sets the ispell-program-name to "aspell" and no longer hangs as it did when it was using hunspell.
Comment 7 Daniel Novotny 2009-07-07 10:27:51 UTC 
(In reply to comment #5)
> Unfortunately nothing has changed yet.  
strange: in the new package, default.el should be empty
Comment 8 Daniel 2009-07-07 13:59:00 UTC 
> > Unfortunately nothing has changed yet.  
> strange: in the new package, default.el should be empty  

yep, compiled the packages from source again 

http://kojipkgs.fedoraproject.org/packages/emacs/22.3/14.fc11/data/signed/d22e77f2/src/emacs-22.3-14.fc11.src.rpm

and it works. Now spell checking seems to be okay. Don't know, what happened last time. Sorry for that & thanx again for fixing.

BTW, compilation went through, but produced a myriad of warnings. Most of it maybe is due to odd emacs code.
Comment 9 Gustavo Maciel Dias Vieira 2009-07-14 19:55:15 UTC 
(In reply to comment #2)
> hello,
> I fixed this in rawhide. 
> 
> In F11 I was waiting for my previous update to hit testing and get tested.
> 
> The solution is this: I removed those lines from default.el and took another
> approach (adding dependency to aspell) to fix Bug 443549 .
> 
> I will push the updated package into F11 now.  

Hi Daniel,

I would like to ask you to reconsider this fix.

As I describe in bug # 495047, the problem isn't with hunspell but with the default dictionary list shipped with emacs. These misconfigured dictionaries are the ones causing the lockups. With a proper configuration I have emacs/hunspell working without a problem. Considering the dictionary unification effort taken in F9 (http://fedoraproject.org/wiki/Releases/FeatureDictionary), I see it as a step backward to add a dependency on aspell to emacs.

As a user, I love the idea of dictionary unification as it allows me to unify my *personal* dictionaries. So, it isn't a "purity" matter.

Maybe for F11 the best solution is just to drop the switch to huspell and let users install aspell thenselves. For F12, the corrected dictionary list could be provided and hunspell reenabled.
Comment 10 Fedora Update System 2009-07-23 19:02:12 UTC 
emacs-22.3-14.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 11 Daniel 2012-02-04 09:37:26 UTC 
Same problem in F16. I can change the dict, but afterwards spell checking does not work and I see errors like "ispell-init-process: Can't open affix or dictionary files for dictionary ..." or "ispell-send-string: Process ispell not running"
As far as I can see emacs-23.3-9.fc16 does not depend on any spell checker. On my system hunspell was present nevertheless and emacs tried to use it: "@(#) International Ispell Version 3.2.06 (but really Hunspell 1.3.2)"

Installing aspell and aspell dictionaries fixed the issue.

I never had problems using emacs + hunspell + english dictionaries, so I guess it should be possible to teach emacs to use other hunspell dictionaries as well. If it is not, emacs should probably depend on aspell to help the user find this workaround.