Bug 534135
Summary: | Review Request: xstream - Java XML serialization library | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> | ||||
Component: | Package Review | Assignee: | Michal Ingeli <mi> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | low | ||||||
Version: | rawhide | CC: | fedora-package-review, jochen, mi, notting | ||||
Target Milestone: | --- | Flags: | mi:
fedora-review+
kevin: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | F13FeatureIDEA | ||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-12-03 09:56:38 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 469894 | ||||||
Bug Blocks: | 534168 | ||||||
Attachments: |
|
Description
Lubomir Rintel
2009-11-10 17:19:54 UTC
RPMLint: xstream.src:198: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/gcj/%{name} xstream.src:199: W: libdir-macro-in-noarch-package (main package) %{_libdir}/gcj/%{name}/%{name}-*%{version}.jar.* False alarms, rpmlint does not grok %if-s. xstream.i686: W: wrong-file-end-of-line-encoding /usr/share/doc/xstream-1.2.2/LICENSE.txt Some packagers prefer not to touch license files and I am one of them. Note to reviewer: I made this depend on bug #469894 which is a dead review. I hope it come back to life, if not I'll open a new one. However, to review this a package you can get there (cglib) is needed. Question: Do you really want the gcj stuff. This will produced an architecture depending package. Jochen, it's conditionally disabled and in fact still used on ppc. I personally don't add it to new packages, but when it's already there I'm reluctant to remove it since it still might be useful for some (powerpc). More on topic: https://www.redhat.com/archives/fedora-devel-java-list/2009-November/msg00024.html Created attachment 373195 [details]
Build log
Failed build log on mock agains fedora-development-x86_64
Jochen: Changed to build with OpenJDK, and since we don't build with gcj, AOT was removed as well. SPEC: http://v3.sk/~lkundrak/SPECS/xstream.spec SRPM: http://v3.sk/~lkundrak/SRPMS/xstream-1.2.2-3.src.rpm - builds in koji - license ok * rpmlint not silent: - xstream.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/xstream-1.2.2/LICENSE.txt I also think, that it's not good to touch license, so this is OK. - xstream.noarch: W: incoherent-version-in-changelog 0:1.2.2-3 ['1.2.2-3', '1.2.2-3'] Remove epoch also from changelog Dropping that AOT seems OK, according to [1] it will be no longer required in F13. APPROVED [1] https://www.redhat.com/archives/fedora-devel-java-list/2009-November/msg00025.html O kruwa, dziekuje. New Package CVS Request ======================= Package Name: xstream Short Description: Java XML serialization library Owners: lkundrak Branches: F-11 F-12 EL-5 @Mical Please assign this bug to you. At least: from my point of view your review is very poor. I'm waiting for the CVS import, because I want to do the review for groovy. (In reply to comment #9) > @Mical > Please assign this bug to you. I already have. > At least: from my point of view your review is very poor. It's more "brief". I tried to build package locally, in mock and finally in koji, and it passed. Another important thing is license, and that's also ok. I gave it another check. There is missing one "must" from java guidelines, and that is "Require: java", jpackage-utils is not enough. - correctly named - source matches upstream - license in %doc - clean, legible, american english * I think, javadoc shouldn't be in %doc, but there is not a guideline for that %doc %{_javadocdir}/%{name}-%{version} * add java require (shame, that I missed this one!) * drop epoch from current changelog entry If you see anything, that is not fulfilling the guidelines, feel free to point it out. (In reply to comment #10) > (In reply to comment #9) > > At least: from my point of view your review is very poor. > > It's more "brief". I tried to build package locally, in mock and finally in > koji, and it passed. Another important thing is license, and that's also ok. Jochen, seriously, what was wrong here? Please point out any deficiencies of the package, I have a feeling that the CVS request might be delayed for this (other, older cvs requests have been processed), so I'd really like to have this cleared up. > I gave it another check. There is missing one "must" from java guidelines, and > that is "Require: java", jpackage-utils is not enough. Fair enough. Fixed. > * I think, javadoc shouldn't be in %doc Fixed. > * drop epoch from current changelog entry Done. New package: SPEC: http://v3.sk/~lkundrak/SPECS/xstream.spec SRPM: http://v3.sk/~lkundrak/SRPMS/xstream-1.2.2-4.fc13.src.rpm cvs done. Imported and built. |